Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: src/compiler/js-type-feedback-lowering.cc

Issue 1319383002: Drop ambiguous MaybeHandle comparison and hashing ops. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_cleanup-includes-unique-2
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-operator.cc ('k') | src/handles.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-type-feedback-lowering.cc
diff --git a/src/compiler/js-type-feedback-lowering.cc b/src/compiler/js-type-feedback-lowering.cc
index 2f106df21ea341a276e8bdc1f5cdb74904354375..6f43c4e8f42cbcd6d3a67b7ff393507e1f7bf3d8 100644
--- a/src/compiler/js-type-feedback-lowering.cc
+++ b/src/compiler/js-type-feedback-lowering.cc
@@ -41,10 +41,9 @@ Reduction JSTypeFeedbackLowering::ReduceJSLoadNamed(Node* node) {
// We need to make optimistic assumptions to continue.
if (!(flags() & kDeoptimizationEnabled)) return NoChange();
LoadNamedParameters const& p = LoadNamedParametersOf(node->op());
- Handle<TypeFeedbackVector> vector;
- if (!p.feedback().vector().ToHandle(&vector)) return NoChange();
+ if (p.feedback().vector().is_null()) return NoChange();
if (p.name().is_identical_to(factory()->length_string())) {
- LoadICNexus nexus(vector, p.feedback().slot());
+ LoadICNexus nexus(p.feedback().vector(), p.feedback().slot());
MapHandleList maps;
if (nexus.ExtractMaps(&maps) > 0) {
for (Handle<Map> map : maps) {
« no previous file with comments | « src/compiler/js-operator.cc ('k') | src/handles.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698