Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1319373003: Enable TestLoadingPublicUsersFromLocalState (Closed)

Created:
5 years, 3 months ago by achuithb
Modified:
5 years, 3 months ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable TestLoadingPublicUsersFromLocalState Ran this test 100 times locally with no failures. Didn't fail on bots either BUG=393708 Committed: https://crrev.com/f189d5356a18e7b5e159c8028184137eb8656e06 Cr-Commit-Position: refs/heads/master@{#347898}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 2 chunks +4 lines, -5 lines 1 comment Download

Messages

Total messages: 14 (4 generated)
achuithb
Bartosz, please take a look. I've run this test locally 100+ times, and on the ...
5 years, 3 months ago (2015-09-08 11:21:11 UTC) #2
bartfab (slow)
https://codereview.chromium.org/1319373003/diff/1/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc File chrome/browser/chromeos/login/existing_user_controller_browsertest.cc (right): https://codereview.chromium.org/1319373003/diff/1/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc#newcode463 chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:463: runner2 = new content::MessageLoopRunner; Oops, that was quite a ...
5 years, 3 months ago (2015-09-08 14:57:17 UTC) #3
achuithb
On 2015/09/08 14:57:17, bartfab wrote: > https://codereview.chromium.org/1319373003/diff/1/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc > File chrome/browser/chromeos/login/existing_user_controller_browsertest.cc > (right): > > https://codereview.chromium.org/1319373003/diff/1/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc#newcode463 ...
5 years, 3 months ago (2015-09-09 08:50:31 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319373003/1
5 years, 3 months ago (2015-09-09 08:51:50 UTC) #6
bartfab (slow)
On 2015/09/09 08:50:31, achuithb wrote: > On 2015/09/08 14:57:17, bartfab wrote: > > > https://codereview.chromium.org/1319373003/diff/1/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc ...
5 years, 3 months ago (2015-09-09 09:04:58 UTC) #7
achuithb
On 2015/09/09 09:04:58, bartfab wrote: > On 2015/09/09 08:50:31, achuithb wrote: > > On 2015/09/08 ...
5 years, 3 months ago (2015-09-09 09:06:08 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-09 09:24:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319373003/1
5 years, 3 months ago (2015-09-09 09:40:22 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 10:06:25 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 10:07:14 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f189d5356a18e7b5e159c8028184137eb8656e06
Cr-Commit-Position: refs/heads/master@{#347898}

Powered by Google App Engine
This is Rietveld 408576698