Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6586)

Unified Diff: chrome/browser/chromeos/login/existing_user_controller_browsertest.cc

Issue 1319373003: Enable TestLoadingPublicUsersFromLocalState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
diff --git a/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc b/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
index 5fbaa050a9a4aba97bd5cbce126e3b18ae921e6b..0402be786024a2923aefc8127f0e69428d3b1d98 100644
--- a/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
+++ b/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
@@ -460,10 +460,10 @@ class ExistingUserControllerPublicSessionTest
if (!proto.has_device_local_accounts() ||
!proto.device_local_accounts().has_auto_login_delay() ||
proto.device_local_accounts().auto_login_delay() != delay) {
- runner1 = new content::MessageLoopRunner;
- subscription1 = chromeos::CrosSettings::Get()->AddSettingsObserver(
+ runner2 = new content::MessageLoopRunner;
bartfab (slow) 2015/09/08 14:57:17 Oops, that was quite a stupid typo. Thanks for fix
+ subscription2 = chromeos::CrosSettings::Get()->AddSettingsObserver(
chromeos::kAccountsPrefDeviceLocalAccountAutoLoginDelay,
- runner1->QuitClosure());
+ runner2->QuitClosure());
}
// Update the policy.
@@ -738,9 +738,8 @@ IN_PROC_BROWSER_TEST_F(ExistingUserControllerPublicSessionTest,
// First run propagates public accounts and stores them in Local State.
}
-// See http://crbug.com/393704; flaky.
IN_PROC_BROWSER_TEST_F(ExistingUserControllerPublicSessionTest,
- DISABLED_TestLoadingPublicUsersFromLocalState) {
+ TestLoadingPublicUsersFromLocalState) {
// Second run loads list of public accounts from Local State.
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698