Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1319153006: [heap] Remove obsolete DisallowAllocationFailure scope. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
Michael Lippautz
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove obsolete DisallowAllocationFailure scope. This removes the DisallowAllocationFailure assertion scope which mostly coincided with the AlwaysAllocateScope anyways. Access to the bitfield in the Isolate was not synchronized and hence the AlwaysAllocateScope was not thread-safe in debug mode, now it is. R=mlippautz@chromium.org Committed: https://crrev.com/6f454aa1a8891125583d5b16e1b45656643df182 Cr-Commit-Position: refs/heads/master@{#30637}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -16 lines) Patch
M src/assert-scope.h View 2 chunks +0 lines, -9 lines 0 comments Download
M src/assert-scope.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/heap-inl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (1 generated)
Michael Starzinger
5 years, 3 months ago (2015-09-08 13:53:25 UTC) #1
Michael Starzinger
5 years, 3 months ago (2015-09-08 13:54:48 UTC) #2
Michael Lippautz
lgtm
5 years, 3 months ago (2015-09-08 14:09:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319153006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319153006/1
5 years, 3 months ago (2015-09-08 14:17:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-08 14:42:34 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 14:43:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f454aa1a8891125583d5b16e1b45656643df182
Cr-Commit-Position: refs/heads/master@{#30637}

Powered by Google App Engine
This is Rietveld 408576698