Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 1314543014: [heap] Prevent leakage of GCCallbacksScope outside of heap. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
Michael Lippautz
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-remove-alloc-failure-scope
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Prevent leakage of GCCallbacksScope outside of heap. R=mlippautz@chromium.org Committed: https://crrev.com/0faceaec7fb961738d9ee9a36b5080a91c8a5abc Cr-Commit-Position: refs/heads/master@{#30642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -25 lines) Patch
M src/heap/heap.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +0 lines, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 3 months ago (2015-09-08 14:17:59 UTC) #1
Michael Lippautz
lgtm
5 years, 3 months ago (2015-09-08 17:12:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314543014/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314543014/1
5 years, 3 months ago (2015-09-08 17:12:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-08 17:14:20 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 17:14:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0faceaec7fb961738d9ee9a36b5080a91c8a5abc
Cr-Commit-Position: refs/heads/master@{#30642}

Powered by Google App Engine
This is Rietveld 408576698