Remove WEBP encoder SkBitmap API

Remove WEBP encoder SkBitmap API

SkBitmap is being removed from Chrome. There are no longer any callers
of WEBPImageEncoder::encode(SkBitmap,...) so we can remove it and also
the support code it required.

No change in behavior, no new tests.

TBR=fmalita@chromium.org
BUG=449197
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201373

[Noel Gordon, 2015-08-28 04:37:47]

noel@chromium.org changed reviewers:
+ fmalita@chromium.org

[Noel Gordon, 2015-08-28 04:39:29]

canvas/ fast/canvas/  fast/image passing locally for me, PTAL.

[Noel Gordon, 2015-08-28 06:01:58]

try tests passing ...

[Noel Gordon, 2015-08-28 06:02:03]

The CQ bit was checked by noel@chromium.org

[commit-bot: I haz the power, 2015-08-28 06:02:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1319113002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1319113002/1

[commit-bot: I haz the power, 2015-08-28 06:06:40]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201373

[f(malita), 2015-08-28 12:33:17]

LGTM!

[urvang, 2015-08-28 17:20:58]

urvang@chromium.org changed reviewers:
+ urvang@chromium.org

[urvang, 2015-08-28 17:20:58]

lgtm

https://codereview.chromium.org/1319113002/diff/1/Source/platform/image-encod...
File Source/platform/image-encoders/skia/WEBPImageEncoder.cpp (right):

https://codereview.chromium.org/1319113002/diff/1/Source/platform/image-encod...
Source/platform/image-encoders/skia/WEBPImageEncoder.cpp:91: if
(!rgbPictureImport(pixels, &WebPPictureImportRGB, &picture))
It would be helpful to put a comment that ImageDataBuffer gives
non-premultiplied pixels in RGBA format.
(You can do this in the next patch).

[Noel Gordon, 2015-09-01 14:46:24]

On 2015/08/28 17:20:58, urvang wrote:

>
https://codereview.chromium.org/1319113002/diff/1/Source/platform/image-encod...
> Source/platform/image-encoders/skia/WEBPImageEncoder.cpp:91: if
> (!rgbPictureImport(pixels, &WebPPictureImportRGB, &picture))
> It would be helpful to put a comment that ImageDataBuffer gives
> non-premultiplied pixels in RGBA format.

Even better to ditch the comment and write it in code ...

https://codereview.chromium.org/1302423004/patch/100001/110013