Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1318973002: Update WebSocketBrowserTest.SSLConnectionLimit test (Closed)

Created:
5 years, 3 months ago by Adam Rice
Modified:
3 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update WebSocketBrowserTest.SSLConnectionLimit test 255 simultanous wss: connections can now be made. Update the WebSocketBrowserTest.SSLConnectionLimit test to reflect the new limit. Depends on http://crrev.com/1130073004 BUG=486800 TEST=browser_tests Review-Url: https://codereview.chromium.org/1318973002 Cr-Commit-Position: refs/heads/master@{#491012} Committed: https://chromium.googlesource.com/chromium/src/+/dbced2bcec41b3567f120091e243169bb276ca93

Patch Set 1 #

Patch Set 2 : Update WebSocketBrowserTest.SSLConnectionLimit test #

Patch Set 3 : Remove comment about needing to update the limit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M net/data/websocket/multiple-connections.html View 1 2 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Adam Rice
3 years, 4 months ago (2017-07-28 08:40:44 UTC) #10
Adam Rice
ping tyoshino. I'd like to land this before Rietveld goes read-only.
3 years, 4 months ago (2017-08-01 13:07:30 UTC) #11
tyoshino (SeeGerritForStatus)
Sorry! lgtm
3 years, 4 months ago (2017-08-01 14:21:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1318973002/40001
3 years, 4 months ago (2017-08-01 14:50:30 UTC) #14
commit-bot: I haz the power
3 years, 4 months ago (2017-08-01 16:39:40 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/dbced2bcec41b3567f120091e243...

Powered by Google App Engine
This is Rietveld 408576698