Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1318933002: Revert of Deprecate 'intrinsic' and 'min-intrinsic' CSS keywords (Closed)

Created:
5 years, 3 months ago by dstockwell
Modified:
5 years, 3 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Deprecate 'intrinsic' and 'min-intrinsic' CSS keywords (patchset #5 id:80001 of https://codereview.chromium.org/1314923005/ ) Reason for revert: Broke WebKit Linux Leak See: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/13676 Original issue's description: > Deprecate 'intrinsic' and 'min-intrinsic' CSS keywords > > Intent to deprecate: https://groups.google.com/a/chromium.org/d/topic/blink-dev/R9JzO74jYvI/discussion > > I plan to merge this to the M46 branch ASAP. > > R=esprehn@chromium.org,yoav@yoav.ws > BUG=475104 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201259 TBR=esprehn@chromium.org,yoav@yoav.ws,cbiesinger@google.com,cbiesinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=475104 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201292

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -58 lines) Patch
M LayoutTests/fast/block/marquee-width-shrinks-to-fit-in-fixed-size-container.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css-intrinsic-dimensions/multicol-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css-intrinsic-dimensions/resources/width-keyword-classes.css View 4 chunks +6 lines, -0 lines 0 comments Download
M LayoutTests/fast/css/deprecated-flex-box-zero-width-intrinsic-max-width-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/zoomed-intrinsic-width.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/zoomed-intrinsic-width-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/html/element-offset-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/table/cell-height-min-intrinsic.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/text/tab-min-size.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/svg-width-intrinsic-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSGroupingRule.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/css/CSSKeyframesRule.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/css/CSSPageRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSStyleRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSStyleSheet.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/css/parser/CSSParserImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSParserMode.h View 4 chunks +1 line, -6 lines 0 comments Download
M Source/core/css/parser/CSSParserMode.cpp View 4 chunks +2 lines, -10 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 2 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dstockwell
Created Revert of Deprecate 'intrinsic' and 'min-intrinsic' CSS keywords
5 years, 3 months ago (2015-08-27 06:24:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318933002/1
5 years, 3 months ago (2015-08-27 06:24:28 UTC) #2
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 06:25:06 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201292

Powered by Google App Engine
This is Rietveld 408576698