Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1318863004: [presubmit] Fix build/include linter violations. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[presubmit] Fix build/include linter violations. R=bmeurer@chromium.org Committed: https://crrev.com/92e85aed109d03498eb8cb5ad1b10e95b1686e42 Cr-Commit-Position: refs/heads/master@{#30554}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -22 lines) Patch
M include/v8.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/v8-debug.h View 1 chunk +1 line, -1 line 0 comments Download
M include/v8-profiler.h View 1 chunk +1 line, -1 line 0 comments Download
M include/v8-testing.h View 1 chunk +1 line, -1 line 0 comments Download
M include/v8-util.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/frames-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/arm64/codegen-arm64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm64/frames-arm64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/base/atomicops_internals_x86_gcc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/base/platform/platform-freebsd.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/base/platform/platform-openbsd.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/base/platform/platform-qnx.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/control-builders.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/flags.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/frames-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/simulator-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/codegen-mips.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips/frames-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/codegen-mips64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips64/frames-mips64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/assembler-ppc.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/codegen-ppc.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ppc/frames-ppc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/lithium-ppc.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/unicode.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/frames-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/simulator-x64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x87/assembler-x87.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/codegen-x87.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x87/frames-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/lithium-x87.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/simulator-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-typedarrays.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/presubmit.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 3 months ago (2015-09-02 11:08:24 UTC) #1
Benedikt Meurer
LGTM!
5 years, 3 months ago (2015-09-02 19:18:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318863004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318863004/1
5 years, 3 months ago (2015-09-03 07:53:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 07:56:01 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 07:56:29 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/92e85aed109d03498eb8cb5ad1b10e95b1686e42
Cr-Commit-Position: refs/heads/master@{#30554}

Powered by Google App Engine
This is Rietveld 408576698