Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Side by Side Diff: tools/presubmit.py

Issue 1318863004: [presubmit] Fix build/include linter violations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-typedarrays.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2012 the V8 project authors. All rights reserved. 3 # Copyright 2012 the V8 project authors. All rights reserved.
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 import sys 43 import sys
44 import subprocess 44 import subprocess
45 import multiprocessing 45 import multiprocessing
46 from subprocess import PIPE 46 from subprocess import PIPE
47 47
48 # Special LINT rules diverging from default and reason. 48 # Special LINT rules diverging from default and reason.
49 # build/header_guard: Our guards have the form "V8_FOO_H_", not "SRC_FOO_H_". 49 # build/header_guard: Our guards have the form "V8_FOO_H_", not "SRC_FOO_H_".
50 # build/include_what_you_use: Started giving false positives for variables 50 # build/include_what_you_use: Started giving false positives for variables
51 # named "string" and "map" assuming that you needed to include STL headers. 51 # named "string" and "map" assuming that you needed to include STL headers.
52 # TODO(bmeurer): Fix and re-enable readability/check 52 # TODO(bmeurer): Fix and re-enable readability/check
53 # TODO(mstarzinger): Fix and re-enable build/include
54 # TODO(mstarzinger): Fix and re-enable readability/namespace 53 # TODO(mstarzinger): Fix and re-enable readability/namespace
55 54
56 LINT_RULES = """ 55 LINT_RULES = """
57 -build/c++11 56 -build/c++11
58 -build/header_guard 57 -build/header_guard
59 -build/include
60 +build/include_alpha 58 +build/include_alpha
61 -build/include_what_you_use 59 -build/include_what_you_use
62 -build/namespaces 60 -build/namespaces
63 -readability/check 61 -readability/check
64 -readability/inheritance 62 -readability/inheritance
65 -readability/namespace 63 -readability/namespace
66 -readability/nolint 64 -readability/nolint
67 +readability/streams 65 +readability/streams
68 -runtime/references 66 -runtime/references
69 -runtime/threadsafe_fn 67 -runtime/threadsafe_fn
(...skipping 390 matching lines...) Expand 10 before | Expand all | Expand 10 after
460 success = SourceProcessor().Run(workspace) and success 458 success = SourceProcessor().Run(workspace) and success
461 success = CheckExternalReferenceRegistration(workspace) and success 459 success = CheckExternalReferenceRegistration(workspace) and success
462 if success: 460 if success:
463 return 0 461 return 0
464 else: 462 else:
465 return 1 463 return 1
466 464
467 465
468 if __name__ == '__main__': 466 if __name__ == '__main__':
469 sys.exit(Main()) 467 sys.exit(Main())
OLDNEW
« no previous file with comments | « test/cctest/test-typedarrays.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698