Eliminate use of CompilationInfo in several AstVisitor descendants.

Eliminate use of CompilationInfo in several AstVisitor descendants.

We're moving away from using CompilationInfo as a big bag o' stuff.
Passing in just what we need to several AstVisitors to avoid
increasing the problem.

BUG=None
TEST=trybots
R=titzer@chromium.org
LOG=N

Committed: https://crrev.com/29d793728abf24d7078809f128d3f82437855ff2
Cr-Commit-Position: refs/heads/master@{#30529}

[titzer, 2015-09-01 21:55:34]

lgtm other than existential questions

https://codereview.chromium.org/1318823010/diff/20001/src/ast-expression-visi...
File src/ast-expression-visitor.h (right):

https://codereview.chromium.org/1318823010/diff/20001/src/ast-expression-visi...
src/ast-expression-visitor.h:25: FunctionLiteral* root);
I think you can drop the "explicit" for multiple argument constructors.

https://codereview.chromium.org/1318823010/diff/20001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/1318823010/diff/20001/src/hydrogen.cc#newcode...
src/hydrogen.cc:8340: .Run();
Why does the AstTyper need the osr_ast_id()?

[bradn, 2015-09-01 22:08:35]

https://codereview.chromium.org/1318823010/diff/20001/src/ast-expression-visi...
File src/ast-expression-visitor.h (right):

https://codereview.chromium.org/1318823010/diff/20001/src/ast-expression-visi...
src/ast-expression-visitor.h:25: FunctionLiteral* root);
On 2015/09/01 21:55:34, titzer wrote:
> I think you can drop the "explicit" for multiple argument constructors.

Done.

https://codereview.chromium.org/1318823010/diff/20001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/1318823010/diff/20001/src/hydrogen.cc#newcode...
src/hydrogen.cc:8340: .Run();
On 2015/09/01 21:55:34, titzer wrote:
> Why does the AstTyper need the osr_ast_id()?

This gets done is ObserveTypesAtOsrEntry:
  if (stmt->OsrEntryId() != osr_ast_id_) return;
Used each time a block is entered.

[bradn, 2015-09-01 22:08:38]

The CQ bit was checked by bradnelson@google.com

[bradn, 2015-09-01 22:08:39]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1318823010/#ps40001
(title: "revised")

[commit-bot: I haz the power, 2015-09-01 22:08:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1318823010/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1318823010/40001

[commit-bot: I haz the power, 2015-09-01 23:06:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-01 23:06:46]

Patchset 3 (id:??) landed as
https://crrev.com/29d793728abf24d7078809f128d3f82437855ff2
Cr-Commit-Position: refs/heads/master@{#30529}