Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Side by Side Diff: test/cctest/expression-type-collector.cc

Issue 1318823010: Eliminate use of CompilationInfo in several AstVisitor descendants. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: revised Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/expression-type-collector.h ('k') | test/cctest/test-asm-validator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "test/cctest/expression-type-collector.h" 7 #include "test/cctest/expression-type-collector.h"
8 8
9 #include "src/ast.h" 9 #include "src/ast.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 10 matching lines...) Expand all
21 #define DECLARE_VISIT(type) \ 21 #define DECLARE_VISIT(type) \
22 { AstNode::k##type, #type } \ 22 { AstNode::k##type, #type } \
23 , 23 ,
24 AST_NODE_LIST(DECLARE_VISIT) 24 AST_NODE_LIST(DECLARE_VISIT)
25 #undef DECLARE_VISIT 25 #undef DECLARE_VISIT
26 }; 26 };
27 } 27 }
28 28
29 29
30 ExpressionTypeCollector::ExpressionTypeCollector( 30 ExpressionTypeCollector::ExpressionTypeCollector(
31 CompilationInfo* info, ZoneVector<ExpressionTypeEntry>* dst) 31 Isolate* isolate, Zone* zone, FunctionLiteral* root,
32 : AstExpressionVisitor(info), result_(dst) {} 32 ZoneVector<ExpressionTypeEntry>* dst)
33 : AstExpressionVisitor(isolate, zone, root), result_(dst) {}
33 34
34 35
35 void ExpressionTypeCollector::Run() { 36 void ExpressionTypeCollector::Run() {
36 result_->clear(); 37 result_->clear();
37 AstExpressionVisitor::Run(); 38 AstExpressionVisitor::Run();
38 } 39 }
39 40
40 41
41 void ExpressionTypeCollector::VisitExpression(Expression* expression) { 42 void ExpressionTypeCollector::VisitExpression(Expression* expression) {
42 ExpressionTypeEntry e; 43 ExpressionTypeEntry e;
43 e.depth = depth(); 44 e.depth = depth();
44 VariableProxy* proxy = expression->AsVariableProxy(); 45 VariableProxy* proxy = expression->AsVariableProxy();
45 if (proxy) { 46 if (proxy) {
46 e.name = proxy->raw_name(); 47 e.name = proxy->raw_name();
47 } 48 }
48 e.bounds = expression->bounds(); 49 e.bounds = expression->bounds();
49 AstNode::NodeType type = expression->node_type(); 50 AstNode::NodeType type = expression->node_type();
50 e.kind = "unknown"; 51 e.kind = "unknown";
51 for (size_t i = 0; i < arraysize(NodeTypeNameList); ++i) { 52 for (size_t i = 0; i < arraysize(NodeTypeNameList); ++i) {
52 if (NodeTypeNameList[i].type == type) { 53 if (NodeTypeNameList[i].type == type) {
53 e.kind = NodeTypeNameList[i].name; 54 e.kind = NodeTypeNameList[i].name;
54 break; 55 break;
55 } 56 }
56 } 57 }
57 result_->push_back(e); 58 result_->push_back(e);
58 } 59 }
59 } 60 }
60 } 61 }
OLDNEW
« no previous file with comments | « test/cctest/expression-type-collector.h ('k') | test/cctest/test-asm-validator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698