Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: third_party/libwebp/BUILD.gn

Issue 1318823008: Un-nest configs in GN files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libwebp/BUILD.gn
diff --git a/third_party/libwebp/BUILD.gn b/third_party/libwebp/BUILD.gn
index 3259ec3fd0e8dacb5de447b434c66f7ee99f3470..d52e1da7ccfa3bd6a3fe6f9947221ee2b8518aae 100644
--- a/third_party/libwebp/BUILD.gn
+++ b/third_party/libwebp/BUILD.gn
@@ -162,6 +162,13 @@ source_set("libwebp_enc") {
]
}
+config("libwebp_utils_warnings") {
+ if (is_clang) {
+ # See https://code.google.com/p/webp/issues/detail?id=253.
+ cflags = [ "-Wno-incompatible-pointer-types" ]
+ }
+}
+
source_set("libwebp_utils") {
sources = [
"utils/bit_reader.c",
@@ -182,12 +189,6 @@ source_set("libwebp_utils") {
all_dependent_configs = [ ":libwebp_config" ]
- config("libwebp_utils_warnings") {
- if (is_clang) {
- # See https://code.google.com/p/webp/issues/detail?id=253.
- cflags = [ "-Wno-incompatible-pointer-types" ]
- }
- }
public_configs = [ ":libwebp_utils_warnings" ]
}

Powered by Google App Engine
This is Rietveld 408576698