Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: third_party/libusb/BUILD.gn

Issue 1318823008: Un-nest configs in GN files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libusb/BUILD.gn
diff --git a/third_party/libusb/BUILD.gn b/third_party/libusb/BUILD.gn
index cce639ea327da46bc41dc93d6468770a284f4bd0..82aeabd3790b918739d20f690143322320ec31cc 100644
--- a/third_party/libusb/BUILD.gn
+++ b/third_party/libusb/BUILD.gn
@@ -10,6 +10,17 @@ config("libusb_config") {
include_dirs = [ "src/libusb" ]
}
+config("libusb_warnings") {
+ visibility = [ ":*" ]
+ if (is_clang) {
+ # guid_eq in windows_usb.c is unused.
+ cflags = [ "-Wno-unused-function" ]
+ if (is_linux && !use_udev) {
+ cflags += [ "-Wno-pointer-sign" ]
+ }
+ }
+}
+
static_library("libusb") {
sources = [
"src/config.h",
@@ -46,15 +57,6 @@ static_library("libusb") {
deps = []
include_dirs = [ "src/libusb/os" ]
- config("libusb_warnings") {
- if (is_clang) {
- # guid_eq in windows_usb.c is unused.
- cflags = [ "-Wno-unused-function" ]
- if (is_linux && !use_udev) {
- cflags += [ "-Wno-pointer-sign" ]
- }
- }
- }
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
configs += [ ":libusb_warnings" ]

Powered by Google App Engine
This is Rietveld 408576698