Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 1318643005: Rename MockMediaSource.Abort into Shutdown (Closed)

Created:
5 years, 3 months ago by servolk
Modified:
5 years, 3 months ago
Reviewers:
chcunningham, wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename MockMediaSource.Abort into Shutdown Also call ChunkDemuxer.Abort before shutting down the demuxer to test that logic as well. BUG=none Committed: https://crrev.com/65465348ce9d806c00a2b6721aa8a3846d0382d8 Cr-Commit-Position: refs/heads/master@{#348287}

Patch Set 1 #

Patch Set 2 : Fixed accidental test renaming #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -28 lines) Patch
M media/test/pipeline_integration_test.cc View 1 28 chunks +31 lines, -28 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (3 generated)
servolk
5 years, 3 months ago (2015-09-10 00:50:27 UTC) #2
servolk
5 years, 3 months ago (2015-09-10 02:04:56 UTC) #4
servolk
On 2015/09/10 02:04:56, servolk wrote: ping
5 years, 3 months ago (2015-09-10 22:33:00 UTC) #5
wolenetz
lgtm
5 years, 3 months ago (2015-09-10 23:35:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318643005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318643005/20001
5 years, 3 months ago (2015-09-10 23:45:22 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-10 23:51:13 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/65465348ce9d806c00a2b6721aa8a3846d0382d8 Cr-Commit-Position: refs/heads/master@{#348287}
5 years, 3 months ago (2015-09-10 23:51:47 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:16:32 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/65465348ce9d806c00a2b6721aa8a3846d0382d8
Cr-Commit-Position: refs/heads/master@{#348287}

Powered by Google App Engine
This is Rietveld 408576698