Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 1318603005: Revert of Replace pinch scrollbars with regular scrollbars. (Closed)

Created:
5 years, 3 months ago by aelias_OOO_until_Jul13
Modified:
5 years, 3 months ago
Reviewers:
skobes, Rick Byers
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, bokan, dshwang, eae+blinkwatch, enne (OOO), jchaffraix+rendering, kenneth.christiansen, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Replace pinch scrollbars with regular scrollbars. (patchset #10 id:180001 of https://codereview.chromium.org/1308053003/ ) Reason for revert: Introduced ChromeDriver devtools mobile emulation crash https://code.google.com/p/chromedriver/issues/detail?id=1205 Original issue's description: > Replace pinch scrollbars with regular scrollbars. > > This patch makes the visual-viewport-managed scrollbars exclusive to > Android and improves normal scrollbars to be usable during pinch as follows: > > 1. Attach the scrollbar layers to the visual viewport, so they're always > onscreen as you zoom in (as already shipped on Mac). > 2. Set the container layer to the inner clip layer, so that the size and > position of the thumb reflects the sum of the two viewports, > instead of just the layout viewport. > > Note that result of these changes is visually indistiguishable at > minimum page scale. It only improves the behavior when zoomed in. > > BUG=523056 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201285 TBR=rbyers@chromium.org,skobes@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=523056 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -142 lines) Patch
M LayoutTests/TestExpectations View 3 chunks +3 lines, -14 lines 0 comments Download
M LayoutTests/compositing/geometry/fixed-position.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/geometry/fixed-position-composited-page-scale.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/geometry/fixed-position-composited-page-scale-down.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale-down.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale-down.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/geometry/vertical-scroll-composited.html View 1 chunk +1 line, -6 lines 0 comments Download
M LayoutTests/compositing/overflow/fixed-position-ancestor-clip.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/compositing/scaling/tiled-layer-recursion.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/repaint/absolute-position-changed.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/scrolling/overflow-clip-with-page-scale.html View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/frame/FrameView.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/frame/VisualViewport.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/frame/VisualViewport.cpp View 7 chunks +25 lines, -34 lines 0 comments Download
M Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/layout/compositing/DeprecatedPaintLayerCompositor.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 3 chunks +4 lines, -6 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerScrollableArea.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/platform/scroll/ScrollableArea.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/scroll/ScrollbarThemeAndroid.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/scroll/ScrollbarThemeOverlay.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeOverlay.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/web/DevToolsEmulator.cpp View 5 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aelias_OOO_until_Jul13
Created Revert of Replace pinch scrollbars with regular scrollbars.
5 years, 3 months ago (2015-08-27 20:08:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318603005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318603005/1
5 years, 3 months ago (2015-08-27 20:08:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201333
5 years, 3 months ago (2015-08-27 20:09:26 UTC) #3
aelias_OOO_until_Jul13
5 years, 3 months ago (2015-08-27 20:38:19 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1305223004/ by aelias@chromium.org.

The reason for reverting is: After discussion with samuong@, the original patch
should be OK to reland as is and https://codereview.chromium.org/1317153002 is
an appropriate fix for the crasher..

Powered by Google App Engine
This is Rietveld 408576698