Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1317153002: [chromedriver] Don't apply device metrics overrides to app and extension pages. (Closed)

Created:
5 years, 3 months ago by samuong
Modified:
5 years, 3 months ago
Reviewers:
stgao
CC:
chromium-reviews, samuong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Don't apply device metrics overrides to app and extension pages. This prevents a renderer crash, and fixes MobileEmulationCapabilityTest.testDeviceMetricsWithStandardWidth, which is currently failing on the Win7 and Mac bots. BUG=chromedriver:1205 TBR=stgao@chromium.org Committed: https://crrev.com/d03cc3e31d21b995c2b9cb26edf63ce71b3256fe Cr-Commit-Position: refs/heads/master@{#345988}

Patch Set 1 #

Patch Set 2 : make sure that |type| is initialized to suppress warning from msvc compiler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M chrome/test/chromedriver/chrome/chrome_desktop_impl.cc View 1 3 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317153002/1
5 years, 3 months ago (2015-08-27 19:55:04 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/96755)
5 years, 3 months ago (2015-08-27 20:07:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317153002/20001
5 years, 3 months ago (2015-08-27 20:45:29 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-27 21:09:39 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d03cc3e31d21b995c2b9cb26edf63ce71b3256fe Cr-Commit-Position: refs/heads/master@{#345988}
5 years, 3 months ago (2015-08-27 21:10:21 UTC) #8
stgao
5 years, 3 months ago (2015-08-31 18:44:57 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698