[Password Manager] Copiable username and origin. Linkable origin elided from the left.

components/password_manager/core/browser/affiliation_utils.h

Index: components/password_manager/core/browser/affiliation_utils.h
diff --git a/components/password_manager/core/browser/affiliation_utils.h b/components/password_manager/core/browser/affiliation_utils.h
index a8f13be7fb40b0f000d63ad3e5768b8a39b32c2b..3dea7d7d95c3e9192b896a418290aadc05a24ab2 100644
--- a/components/password_manager/core/browser/affiliation_utils.h
+++ b/components/password_manager/core/browser/affiliation_utils.h
@@ -206,6 +206,10 @@ bool IsAffiliationRequestsForDummyFacetsEnabled(
 std::string GetHumanReadableOrigin(const autofill::PasswordForm& password_form,
                                    const std::string& languages);
 
+// Remove prefixes "m.", "mobile." or "www." from the result of

[Evan Stade, 2015/10/05 18:59:41]

nit: this kind of comment is likely to get out of sync with code and not be
updated. I think it should be a bit more generic:

// Returns a string suitable for display to the user ...

less of a nit: I don't understand why this is different from
GetHumanReadableOrigin. How is "human readable" distinct from "shown"? Hopefully
we wouldn't show something that's human unreadable :)

[kolos1, 2015/10/06 18:52:33]

Yes, I agree, but there are many ways to get "human readable" origin. For
example, GetHumanReadableOrigin always shows the scheme. GetShownOrigin always
omit scheme. As I understand, we should describe the difference. 

I was going to say that GetShownOrigin copies the behavior of
FormatUrlForSecurityDisplayOmitScheme and also removes the prefixes. The comment
to FormatUrlForSecurityDisplayOmitScheme looks similar. 

Changed. Please review. 

+// |FormatUrlForSecurityDisplayOmitScheme| based on |url| and |languages|.
+std::string GetShownOrigin(const GURL& url, const std::string& languages);
+
 // For logging use only.
 std::ostream& operator<<(std::ostream& os, const FacetURI& facet_uri);