[Password Manager] Copiable username and origin. Linkable origin elided from the left.

components/password_manager/core/browser/affiliation_utils.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains utilities related to working with "facets".
 //
 // A "facet" is defined as the manifestation of a logical application on a given
 // platform. For example, "My Bank" may have released an Android application
 // and a Web application accessible from a browser. These are all facets of the
 // "My Bank" logical application.
@@ skipping 188 matching lines @@
 bool IsAffiliationRequestsForDummyFacetsEnabled(
     const base::CommandLine& command_line);
 
 // Returns the origin URI in a format which can be presented to a user based of
 // |password_from| field values. For web URIs |languages| is using in order to
 // determine whether a URI is 'comprehensible' to a user who understands
 // languages listed.
 std::string GetHumanReadableOrigin(const autofill::PasswordForm& password_form,
                                    const std::string& languages);
 
+// Remove prefixes "m.", "mobile." or "www." from the result of

[Evan Stade, 2015/10/05 18:59:41]

nit: this kind of comment is likely to get out of sync with code and not be
updated. I think it should be a bit more generic:

// Returns a string suitable for display to the user ...

less of a nit: I don't understand why this is different from
GetHumanReadableOrigin. How is "human readable" distinct from "shown"? Hopefully
we wouldn't show something that's human unreadable :)

[kolos1, 2015/10/06 18:52:33]

Yes, I agree, but there are many ways to get "human readable" origin. For
example, GetHumanReadableOrigin always shows the scheme. GetShownOrigin always
omit scheme. As I understand, we should describe the difference. 

I was going to say that GetShownOrigin copies the behavior of
FormatUrlForSecurityDisplayOmitScheme and also removes the prefixes. The comment
to FormatUrlForSecurityDisplayOmitScheme looks similar. 

Changed. Please review. 

+// |FormatUrlForSecurityDisplayOmitScheme| based on |url| and |languages|.
+std::string GetShownOrigin(const GURL& url, const std::string& languages);
+
 // For logging use only.
 std::ostream& operator<<(std::ostream& os, const FacetURI& facet_uri);
 
 }  // namespace password_manager
 
 // Provide a hash function so that hash_sets and maps can contain FacetURIs.
 namespace BASE_HASH_NAMESPACE {
 
 template <>
 struct hash<password_manager::FacetURI> {
   size_t operator()(const password_manager::FacetURI& facet_uri) const {
     return hash<std::string>()(facet_uri.potentially_invalid_spec());
   }
 };
 
 }  // namespace BASE_HASH_NAMESPACE
 
 #endif  // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_AFFILIATION_UTILS_H_