Remove |requestor_url| from ApplicationManager::ConnectToApplication().

Remove |requestor_url| from ApplicationManager::ConnectToApplication().

BUG=None

Committed: https://crrev.com/3b69954d1d15cf96973789f3e58087792cc25903
Cr-Commit-Position: refs/heads/master@{#347243}

[yzshen1, 2015-09-03 17:59:35]

yzshen@chromium.org changed reviewers:
+ sky@chromium.org

[yzshen1, 2015-09-03 18:02:41]

Hi, Scott.

Would you please take a look at this trivial CL?

It depends on https://codereview.chromium.org/1307273004/, and simply removes
the obsolete |requestor_url| parameter.

(I didn't do it in 1307273004 trying to reduce the size of the modified file
list.)

Thanks!

[sky, 2015-09-03 19:48:52]

LGTM

https://codereview.chromium.org/1318523007/diff/1/mojo/shell/application_mana...
File mojo/shell/application_manager.h (right):

https://codereview.chromium.org/1318523007/diff/1/mojo/shell/application_mana...
mojo/shell/application_manager.h:91: URLRequestPtr app_url_request,
I think requested_url is more descriptive.

[yzshen1, 2015-09-03 19:52:58]

https://codereview.chromium.org/1318523007/diff/1/mojo/shell/application_mana...
File mojo/shell/application_manager.h (right):

https://codereview.chromium.org/1318523007/diff/1/mojo/shell/application_mana...
mojo/shell/application_manager.h:91: URLRequestPtr app_url_request,
On 2015/09/03 19:48:52, sky wrote:
> I think requested_url is more descriptive.

I tried to use exactly the same names as the fields in
ConnectToApplicationParams.

In Params, we have |app_url| (GURL) and the corresponding |app_url_request|
(URLRequestPtr).

If we use |requested_url| in place of |app_url|, it seems awkward to change
|app_url_request| to |requestd_url_request|. What do you think? Thanks!

[sky, 2015-09-03 19:58:18]

LGTM

https://codereview.chromium.org/1318523007/diff/1/mojo/shell/application_mana...
File mojo/shell/application_manager.h (right):

https://codereview.chromium.org/1318523007/diff/1/mojo/shell/application_mana...
mojo/shell/application_manager.h:91: URLRequestPtr app_url_request,
On 2015/09/03 19:52:58, yzshen1 wrote:
> On 2015/09/03 19:48:52, sky wrote:
> > I think requested_url is more descriptive.
> 
> I tried to use exactly the same names as the fields in
> ConnectToApplicationParams.
> 
> In Params, we have |app_url| (GURL) and the corresponding |app_url_request|
> (URLRequestPtr).
> 
> If we use |requested_url| in place of |app_url|, it seems awkward to change
> |app_url_request| to |requestd_url_request|. What do you think? Thanks!
> 

You are right, sounds good.

[yzshen1, 2015-09-03 19:58:55]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2015-09-03 19:59:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1318523007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1318523007/1

[commit-bot: I haz the power, 2015-09-03 21:13:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-09-03 21:14:13]

Patchset 1 (id:??) landed as
https://crrev.com/3b69954d1d15cf96973789f3e58087792cc25903
Cr-Commit-Position: refs/heads/master@{#347243}