Remove |requestor_url| from ApplicationManager::ConnectToApplication().

mojo/shell/application_manager.h

Index: mojo/shell/application_manager.h
diff --git a/mojo/shell/application_manager.h b/mojo/shell/application_manager.h
index b28c18d5a0e86289a6dc18a344775c06fc5431d5..1f9bf0c07c1d1e63b1607c280e7c04aaf02a5b8c 100644
--- a/mojo/shell/application_manager.h
+++ b/mojo/shell/application_manager.h
@@ -84,15 +84,15 @@ class ApplicationManager {
   // |originator| can be NULL (e.g. for the first application or in tests), but
   // typically is non-NULL and identifies the instance initiating the
   // connection.
-  // TODO(yzshen): Remove |requestor_url|.
+  // Please see the comments in connect_to_application_params.h for more details
+  // about the parameters.
   void ConnectToApplication(
       ApplicationInstance* originator,
-      URLRequestPtr requested_url,
+      URLRequestPtr app_url_request,

[sky, 2015/09/03 19:48:52]

I think requested_url is more descriptive.

[yzshen1, 2015/09/03 19:52:58]

I tried to use exactly the same names as the fields in
ConnectToApplicationParams.

In Params, we have |app_url| (GURL) and the corresponding |app_url_request|
(URLRequestPtr).

If we use |requested_url| in place of |app_url|, it seems awkward to change
|app_url_request| to |requestd_url_request|. What do you think? Thanks!

[sky, 2015/09/03 19:58:18]

You are right, sounds good.

       const std::string& qualifier,
-      const GURL& requestor_url,
       InterfaceRequest<ServiceProvider> services,
       ServiceProviderPtr exposed_services,
-      const CapabilityFilter& capability_filter,
+      const CapabilityFilter& filter,
       const base::Closure& on_application_end,
       const Shell::ConnectToApplicationCallback& connect_callback);