content/common/text_input_client_messages.h - Issue 1318483007: Implement "Look Up In Dictionary" context menu item asynchronously. (OS X)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/text_input_client_messages.h

Issue 1318483007: Implement "Look Up In Dictionary" context menu item asynchronously. (OS X) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed review comments. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/text_input_client_message_filter.mm ('k') | content/renderer/text_input_client_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/text_input_client_messages.h

diff --git a/content/common/text_input_client_messages.h b/content/common/text_input_client_messages.h

index 860bf10911bc920d44f284af652e56ddec83d8c6..8bd0db29e0c76fc622dd42205a1e9fe1d2084b84 100644

--- a/content/common/text_input_client_messages.h

+++ b/content/common/text_input_client_messages.h

@@ -53,8 +53,9 @@ IPC_MESSAGE_ROUTED1(TextInputClientReplyMsg_GotFirstRectForRange,

#if defined(OS_MACOSX)

// Reply message for TextInputClientMsg_StringForRange.

-IPC_MESSAGE_ROUTED1(TextInputClientReplyMsg_GotStringForRange,

- mac::AttributedStringCoder::EncodedString)

+IPC_MESSAGE_ROUTED2(TextInputClientReplyMsg_GotStringForRange,

+ mac::AttributedStringCoder::EncodedString,

+ gfx::Point)

// Reply message for TextInputClientMsg_StringAtPoint

IPC_MESSAGE_ROUTED2(TextInputClientReplyMsg_GotStringAtPoint,