Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1401)

Unified Diff: content/browser/renderer_host/text_input_client_message_filter.mm

Issue 1318483007: Implement "Look Up In Dictionary" context menu item asynchronously. (OS X) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed review comments. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/text_input_client_message_filter.mm
diff --git a/content/browser/renderer_host/text_input_client_message_filter.mm b/content/browser/renderer_host/text_input_client_message_filter.mm
index 090daaa522da775d882171ee5a52ffb623bbee36..34e9467826d3134c310a77d75941a4225ac98356 100644
--- a/content/browser/renderer_host/text_input_client_message_filter.mm
+++ b/content/browser/renderer_host/text_input_client_message_filter.mm
@@ -65,13 +65,13 @@ void TextInputClientMessageFilter::OnGotFirstRectForRange(
}
void TextInputClientMessageFilter::OnGotStringFromRange(
- const mac::AttributedStringCoder::EncodedString& encoded_string) {
+ const mac::AttributedStringCoder::EncodedString& encoded_string,
+ const gfx::Point& point) {
TextInputClientMac* service = TextInputClientMac::GetInstance();
NSAttributedString* string =
mac::AttributedStringCoder::Decode(&encoded_string);
- if (![string length])
- string = nil;
- service->SetSubstringAndSignal(string);
+ service->GetStringFromRangeReply(
+ string, NSPointFromCGPoint(point.ToCGPoint()));
}
} // namespace content
« no previous file with comments | « content/browser/renderer_host/text_input_client_message_filter.h ('k') | content/common/text_input_client_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698