Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: third_party/WebKit/Source/modules/mediastream/MediaTrackConstraintSet.idl

Issue 1318393002: Refactor "track options" to be a dictionary. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Used MediaTrackConstraintSet in union types Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediastream/MediaTrackConstraintSet.idl
diff --git a/third_party/WebKit/Source/modules/mediastream/MediaTrackConstraintSet.idl b/third_party/WebKit/Source/modules/mediastream/MediaTrackConstraintSet.idl
new file mode 100644
index 0000000000000000000000000000000000000000..4438a1a48433f3dc05be076e3c66117ef7b1d741
--- /dev/null
+++ b/third_party/WebKit/Source/modules/mediastream/MediaTrackConstraintSet.idl
@@ -0,0 +1,12 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
Peter Beverloo 2015/10/05 13:49:09 micro nit: Please link to the spec: // https://w3
hta - Chromium 2015/10/05 21:28:06 Done.
+dictionary MediaTrackConstraintSet {
+ // The "mandatory" and "optional" members are retained for conformance
+ // with http://www.w3.org/TR/2013/WD-mediacapture-streams-20130903/
+ // Next line doesn't compile - crbug/524357
Peter Beverloo 2015/10/05 13:49:09 What does "Next line doesn't compile" mean? Try-bo
hta - Chromium 2015/10/05 21:28:06 That I'd forgotten to remove the comment :-( (emba
+ Dictionary mandatory;
+ sequence<Dictionary> _optional;
+ DOMString foobar;
Peter Beverloo 2015/10/05 13:49:09 Please remove this line.
hta - Chromium 2015/10/05 21:28:06 Done.
+};

Powered by Google App Engine
This is Rietveld 408576698