third_party/WebKit/Source/modules/mediastream/MediaTrackConstraintSet.idl - Issue 1318393002: Refactor "track options" to be a dictionary.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/mediastream/MediaTrackConstraintSet.idl

Issue 1318393002: Refactor "track options" to be a dictionary. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Used MediaTrackConstraintSet in union types Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« third_party/WebKit/Source/modules/mediastream/MediaStreamConstraints.idl ('K') | « third_party/WebKit/Source/modules/mediastream/MediaStreamConstraints.idl ('k') | third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp » ('j') | third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4
	Peter Beverloo 2015/10/05 13:49:09 micro nit: Please link to the spec: // https://w3 micro nit: Please link to the spec: // https://w3c.github.io/mediacapture-main/getusermedia.html#idl-def-MediaTrackC... hta - Chromium 2015/10/05 21:28:06 Done. Show quoted text On 2015/10/05 13:49:09, Peter Beverloo wrote: > micro nit: Please link to the spec: > > // > https://w3c.github.io/mediacapture-main/getusermedia.html#idl-def-MediaTrackC... Done.
	5 dictionary MediaTrackConstraintSet {

	6 // The "mandatory" and "optional" members are retained for conformance

	7 // with http://www.w3.org/TR/2013/WD-mediacapture-streams-20130903/

	8 // Next line doesn't compile - crbug/524357
	Peter Beverloo 2015/10/05 13:49:09 What does "Next line doesn't compile" mean? Try-bo What does "Next line doesn't compile" mean? Try-bots are proving you wrong :) nit: crbug.com/524357 hta - Chromium 2015/10/05 21:28:06 That I'd forgotten to remove the comment :-( (emba Show quoted text On 2015/10/05 13:49:09, Peter Beverloo wrote: > What does "Next line doesn't compile" mean? Try-bots are proving you wrong :) > > nit: crbug.com/524357 That I'd forgotten to remove the comment :-( (embarraassed)
	9 Dictionary mandatory;

	10 sequence<Dictionary> _optional;

	11 DOMString foobar;
	Peter Beverloo 2015/10/05 13:49:09 Please remove this line. Please remove this line. hta - Chromium 2015/10/05 21:28:06 Done. Show quoted text On 2015/10/05 13:49:09, Peter Beverloo wrote: > Please remove this line. Done.
	12 };

OLD	NEW