Issue 1318343004: Merge to XFA: CJS_Context::compile unused

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1318343004: Merge to XFA: CJS_Context::compile unused (Closed)

Created:
5 years, 3 months ago by Tom Sepez

Modified:
5 years, 3 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: CJS_Context::compile unused Manual merge in fpdfsdk/src/javascript/JS_Context.cpp (cherry picked from commit 6e945a1ebbacde3ed2a4fc83ccb7215ccbc46931) Original Review URL: https://codereview.chromium.org/1318543012 . R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/9ed941a3709dc27ab8c7b27941197c6238f201a3

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -118 lines)			Patch
M	fpdfsdk/include/javascript/IJavaScript.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	fpdfsdk/include/javascript/JS_Context.h	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	fpdfsdk/include/jsapi/fxjs_v8.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Context.cpp	View	10 chunks	+10 lines, -80 lines	0 comments	Download
M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View	1 chunk	+1 line, -24 lines	0 comments	Download

Total messages: 3 (0 generated)

Lei Zhang

lgtm AFAICT, the only difference is |locker| which has been moved from/to the same place.

5 years, 3 months ago (2015-09-01 00:35:16 UTC) #2

Tom Sepez

5 years, 3 months ago (2015-09-01 16:51:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9ed941a3709dc27ab8c7b27941197c6238f201a3 (presubmit successful).