Issue 1318543012: CJS_Context::compile unused

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1318543012: CJS_Context::compile unused (Closed)

Created:
5 years, 3 months ago by Tom Sepez

Modified:
5 years, 3 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

CJS_Context::compile unused This, in turn, allows us to get rid of the DoJob method and its clumsy mode parameter conditional. Add explicit and consts, and remove pointless asserts along the way. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6e945a1ebbacde3ed2a4fc83ccb7215ccbc46931

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -117 lines)			Patch
M	fpdfsdk/include/javascript/IJavaScript.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	fpdfsdk/include/javascript/JS_Context.h	View		2 chunks	+3 lines, -7 lines	0 comments	Download
M	fpdfsdk/include/jsapi/fxjs_v8.h	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Context.cpp	View	1 2 3	10 chunks	+9 lines, -79 lines	0 comments	Download
M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View	1	1 chunk	+1 line, -24 lines	0 comments	Download

Total messages: 6 (1 generated)

Tom Sepez

5 years, 3 months ago (2015-08-31 23:54:47 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
6e945a1ebbacde3ed2a4fc83ccb7215ccbc46931 (presubmit successful).