Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp - Issue 1318293002: Only expose Notification.requestPermission() on the Window global.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

Issue 1318293002: Only expose Notification.requestPermission() on the Window global. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: handle detached contexts Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/templates/interface_base.cpp ('K') | « Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp ('k') | Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | Source/bindings/tests/results/modules/V8TestInterface5.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp b/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

index b3417a47de74dfb2dc0aa006edbc950cd2e6ecb9..c6f9d9be0571a25d33874deb2e24ddcead061f75 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

@@ -201,6 +201,8 @@ static void installV8TestInterfaceWillBeGarbageCollectedTemplate(v8::Local<v8::F

ALLOW_UNUSED_LOCAL(instanceTemplate);

v8::Local<v8::ObjectTemplate> prototypeTemplate = functionTemplate->PrototypeTemplate();

ALLOW_UNUSED_LOCAL(prototypeTemplate);

+ ExecutionContext* context = currentExecutionContext(isolate);

+ ALLOW_UNUSED_LOCAL(context);

const V8DOMConfiguration::MethodConfiguration funcMethodConfiguration = {

"func", TestInterfaceWillBeGarbageCollectedV8Internal::funcMethodCallback, 0, 1, V8DOMConfiguration::ExposedToAllScripts,

};