Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: Source/bindings/templates/interface_base.cpp

Issue 1318293002: Only expose Notification.requestPermission() on the Window global. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: handle detached contexts Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/templates/interface_base.cpp
diff --git a/Source/bindings/templates/interface_base.cpp b/Source/bindings/templates/interface_base.cpp
index 04e6782ca7a7b43563018bb2f3a7a3580c0c7135..88586c46b259e03fe44db2508c4b32099d02663a 100644
--- a/Source/bindings/templates/interface_base.cpp
+++ b/Source/bindings/templates/interface_base.cpp
@@ -339,6 +339,10 @@ static void install{{v8_class}}Template(v8::Local<v8::FunctionTemplate> function
ALLOW_UNUSED_LOCAL(instanceTemplate);
v8::Local<v8::ObjectTemplate> prototypeTemplate = functionTemplate->PrototypeTemplate();
ALLOW_UNUSED_LOCAL(prototypeTemplate);
+ {% if custom_registration_methods %}
+ ExecutionContext* context = currentExecutionContext(isolate);
Peter Beverloo 2015/08/28 15:58:58 This will only be needed for *one* use of |custom_
haraken 2015/08/29 08:04:57 Would you help me understand where the context is
+ ALLOW_UNUSED_LOCAL(context);
+ {% endif %}
{% if has_access_check_callbacks %}
instanceTemplate->SetAccessCheckCallbacks({{cpp_class}}V8Internal::namedSecurityCheck, {{cpp_class}}V8Internal::indexedSecurityCheck, v8::External::New(isolate, const_cast<WrapperTypeInfo*>(&{{v8_class}}::wrapperTypeInfo)));
{% endif %}

Powered by Google App Engine
This is Rietveld 408576698