Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Side by Side Diff: Source/web/WebViewImpl.cpp

Issue 1318283003: Organize Layout/Paint-related hooks (blink-side). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/loader/FrameLoaderClient.h ('k') | public/web/WebViewClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1889 matching lines...) Expand 10 before | Expand all | Expand 10 after
1900 for (size_t i = 0; i < m_linkHighlights.size(); ++i) 1900 for (size_t i = 0; i < m_linkHighlights.size(); ++i)
1901 m_linkHighlights[i]->updateGeometry(); 1901 m_linkHighlights[i]->updateGeometry();
1902 1902
1903 if (FrameView* view = mainFrameImpl()->frameView()) { 1903 if (FrameView* view = mainFrameImpl()->frameView()) {
1904 LocalFrame* frame = mainFrameImpl()->frame(); 1904 LocalFrame* frame = mainFrameImpl()->frame();
1905 1905
1906 if (m_shouldDispatchFirstVisuallyNonEmptyLayout && view->isVisuallyNonEm pty()) { 1906 if (m_shouldDispatchFirstVisuallyNonEmptyLayout && view->isVisuallyNonEm pty()) {
1907 m_shouldDispatchFirstVisuallyNonEmptyLayout = false; 1907 m_shouldDispatchFirstVisuallyNonEmptyLayout = false;
1908 // TODO(esprehn): Move users of this callback to something 1908 // TODO(esprehn): Move users of this callback to something
1909 // better, the heuristic for "visually non-empty" is bad. 1909 // better, the heuristic for "visually non-empty" is bad.
1910 // TODO(dglazkov): This should likely be a WebViewClient API. 1910 // TODO(dglazkov): Remove this line after https://codereview.chromiu m.org/1319073003 lands.
1911 frame->loader().client()->dispatchDidFirstVisuallyNonEmptyLayout(); 1911 frame->loader().client()->dispatchDidFirstVisuallyNonEmptyLayout();
1912 client()->didFirstVisuallyNonEmptyLayout();
1912 } 1913 }
1913 1914
1914 if (m_shouldDispatchFirstLayoutAfterFinishedParsing && frame->document() ->hasFinishedParsing()) { 1915 if (m_shouldDispatchFirstLayoutAfterFinishedParsing && frame->document() ->hasFinishedParsing()) {
1915 m_shouldDispatchFirstLayoutAfterFinishedParsing = false; 1916 m_shouldDispatchFirstLayoutAfterFinishedParsing = false;
1916 client()->didFirstLayoutAfterFinishedParsing(); 1917 client()->didFirstLayoutAfterFinishedParsing();
1917 } 1918 }
1918 } 1919 }
1919 } 1920 }
1920 1921
1921 void WebViewImpl::paint(WebCanvas* canvas, const WebRect& rect) 1922 void WebViewImpl::paint(WebCanvas* canvas, const WebRect& rect)
(...skipping 2504 matching lines...) Expand 10 before | Expand all | Expand 10 after
4426 if (m_pageColorOverlay) 4427 if (m_pageColorOverlay)
4427 m_pageColorOverlay->update(); 4428 m_pageColorOverlay->update();
4428 if (InspectorOverlayImpl* overlay = inspectorOverlay()) { 4429 if (InspectorOverlayImpl* overlay = inspectorOverlay()) {
4429 PageOverlay* inspectorPageOverlay = overlay->pageOverlay(); 4430 PageOverlay* inspectorPageOverlay = overlay->pageOverlay();
4430 if (inspectorPageOverlay) 4431 if (inspectorPageOverlay)
4431 inspectorPageOverlay->update(); 4432 inspectorPageOverlay->update();
4432 } 4433 }
4433 } 4434 }
4434 4435
4435 } // namespace blink 4436 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/loader/FrameLoaderClient.h ('k') | public/web/WebViewClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698