Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1318093002: Simplify parseShadowValue (Closed)

Created:
5 years, 3 months ago by rwlbuis
Modified:
5 years, 3 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, blink-reviews-css, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Simplify parseShadowValue Simplify parseShadowValue by getting rid of ShadowParseContext. BUG=404023 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201874

Patch Set 1 #

Patch Set 2 : Fix compilation #

Patch Set 3 : Fix some problems #

Patch Set 4 : Fix more problems #

Total comments: 10

Patch Set 5 : Address review comments #

Patch Set 6 : Fix ASSERT #

Total comments: 2

Patch Set 7 : Remove default params #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -168 lines) Patch
M Source/core/css/parser/CSSPropertyParser.h View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 5 6 3 chunks +72 lines, -168 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
rwlbuis
PTAL. I am not sure it can be simplified any more since there is a ...
5 years, 3 months ago (2015-08-31 22:25:42 UTC) #3
Timothy Loh
BTW this doesn't really get us closer to removing CSSParserValue, especially if we're going to ...
5 years, 3 months ago (2015-09-01 07:18:08 UTC) #4
rwlbuis
PTAL. I agree this doesn't really get us closer to removing CSSParserValue, but you did ...
5 years, 3 months ago (2015-09-02 22:38:59 UTC) #5
Timothy Loh
OK for the color inset length length case, seems FF and IE both reject this ...
5 years, 3 months ago (2015-09-04 05:04:51 UTC) #6
rwlbuis
On 2015/09/04 05:04:51, Timothy Loh wrote: > OK for the color inset length length case, ...
5 years, 3 months ago (2015-09-04 16:00:42 UTC) #8
Timothy Loh
lgtm
5 years, 3 months ago (2015-09-07 01:44:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318093002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318093002/160001
5 years, 3 months ago (2015-09-07 11:56:05 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 13:13:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #7 (id:160001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201874

Powered by Google App Engine
This is Rietveld 408576698