Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Side by Side Diff: Source/core/css/parser/CSSPropertyParser.h

Issue 1318093002: Simplify parseShadowValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix ASSERT Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 3 * Copyright (C) 2004, 2005, 2006, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
4 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2009 - 2010 Torch Mobile (Beijing) Co. Ltd. All rights reserve d. 5 * Copyright (C) 2009 - 2010 Torch Mobile (Beijing) Co. Ltd. All rights reserve d.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 26 matching lines...) Expand all
37 class CSSFunctionValue; 37 class CSSFunctionValue;
38 class CSSGradientValue; 38 class CSSGradientValue;
39 class CSSGridLineNamesValue; 39 class CSSGridLineNamesValue;
40 class CSSLineBoxContainValue; 40 class CSSLineBoxContainValue;
41 struct CSSParserString; 41 struct CSSParserString;
42 struct CSSParserValue; 42 struct CSSParserValue;
43 class CSSParserValueList; 43 class CSSParserValueList;
44 class CSSPrimitiveValue; 44 class CSSPrimitiveValue;
45 class CSSProperty; 45 class CSSProperty;
46 class CSSQuadValue; 46 class CSSQuadValue;
47 class CSSShadowValue;
47 class CSSValue; 48 class CSSValue;
48 class CSSValueList; 49 class CSSValueList;
49 class StylePropertyShorthand; 50 class StylePropertyShorthand;
50 51
51 // Inputs: PropertyID, isImportant bool, CSSParserValueList. 52 // Inputs: PropertyID, isImportant bool, CSSParserValueList.
52 // Outputs: Vector of CSSProperties 53 // Outputs: Vector of CSSProperties
53 54
54 class CSSPropertyParser { 55 class CSSPropertyParser {
55 STACK_ALLOCATED(); 56 STACK_ALLOCATED();
56 public: 57 public:
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 PassRefPtrWillBeRawPtr<CSSValueList> parseFontFaceSrc(); 204 PassRefPtrWillBeRawPtr<CSSValueList> parseFontFaceSrc();
204 PassRefPtrWillBeRawPtr<CSSValueList> parseFontFaceUnicodeRange(); 205 PassRefPtrWillBeRawPtr<CSSValueList> parseFontFaceUnicodeRange();
205 206
206 bool parseSVGValue(CSSPropertyID propId, bool important); 207 bool parseSVGValue(CSSPropertyID propId, bool important);
207 PassRefPtrWillBeRawPtr<CSSValue> parseSVGStrokeDasharray(); 208 PassRefPtrWillBeRawPtr<CSSValue> parseSVGStrokeDasharray();
208 209
209 PassRefPtrWillBeRawPtr<CSSValue> parsePaintOrder() const; 210 PassRefPtrWillBeRawPtr<CSSValue> parsePaintOrder() const;
210 211
211 // CSS3 Parsing Routines (for properties specific to CSS3) 212 // CSS3 Parsing Routines (for properties specific to CSS3)
212 PassRefPtrWillBeRawPtr<CSSValueList> parseShadow(CSSParserValueList*, CSSPro pertyID); 213 PassRefPtrWillBeRawPtr<CSSValueList> parseShadow(CSSParserValueList*, CSSPro pertyID);
214 PassRefPtrWillBeRawPtr<CSSShadowValue> parseSingleShadow(CSSParserValueList* , bool allowInset = false, unsigned maxLength = 4);
Timothy Loh 2015/09/04 05:04:51 Maybe just allowSpread instead of maxLength? Also
213 bool parseBorderImageShorthand(CSSPropertyID, bool important); 215 bool parseBorderImageShorthand(CSSPropertyID, bool important);
214 PassRefPtrWillBeRawPtr<CSSValue> parseBorderImage(CSSPropertyID); 216 PassRefPtrWillBeRawPtr<CSSValue> parseBorderImage(CSSPropertyID);
215 bool parseBorderImageRepeat(RefPtrWillBeRawPtr<CSSValue>&); 217 bool parseBorderImageRepeat(RefPtrWillBeRawPtr<CSSValue>&);
216 bool parseBorderImageSlice(CSSPropertyID, RefPtrWillBeRawPtr<CSSBorderImageS liceValue>&); 218 bool parseBorderImageSlice(CSSPropertyID, RefPtrWillBeRawPtr<CSSBorderImageS liceValue>&);
217 bool parseBorderImageWidth(RefPtrWillBeRawPtr<CSSQuadValue>&); 219 bool parseBorderImageWidth(RefPtrWillBeRawPtr<CSSQuadValue>&);
218 bool parseBorderImageOutset(RefPtrWillBeRawPtr<CSSQuadValue>&); 220 bool parseBorderImageOutset(RefPtrWillBeRawPtr<CSSQuadValue>&);
219 bool parseBorderRadius(CSSPropertyID, bool important); 221 bool parseBorderRadius(CSSPropertyID, bool important);
220 222
221 PassRefPtrWillBeRawPtr<CSSValue> parseReflect(); 223 PassRefPtrWillBeRawPtr<CSSValue> parseReflect();
222 224
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
378 bool m_implicitShorthand; 380 bool m_implicitShorthand;
379 RefPtrWillBeMember<CSSCalcValue> m_parsedCalculation; 381 RefPtrWillBeMember<CSSCalcValue> m_parsedCalculation;
380 }; 382 };
381 383
382 CSSPropertyID unresolvedCSSPropertyID(const CSSParserString&); 384 CSSPropertyID unresolvedCSSPropertyID(const CSSParserString&);
383 CSSValueID cssValueKeywordID(const CSSParserString&); 385 CSSValueID cssValueKeywordID(const CSSParserString&);
384 386
385 } // namespace blink 387 } // namespace blink
386 388
387 #endif // CSSPropertyParser_h 389 #endif // CSSPropertyParser_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/css/parser/CSSPropertyParser.cpp » ('j') | Source/core/css/parser/CSSPropertyParser.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698