pkg/compiler/lib/src/js_backend/patch_resolver.dart - Issue 1318043005: Support user generated custom native JS classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/patch_resolver.dart

Issue 1318043005: Support user generated custom native JS classes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: PTAL Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/patch_resolver.dart

diff --git a/pkg/compiler/lib/src/js_backend/patch_resolver.dart b/pkg/compiler/lib/src/js_backend/patch_resolver.dart

index aea3cbfcf45b8799f8fa9c3f5897f834421f81ee..0b1c5f00d218872d15d5adcd82cafd4f42f649c6 100644

--- a/pkg/compiler/lib/src/js_backend/patch_resolver.dart

+++ b/pkg/compiler/lib/src/js_backend/patch_resolver.dart

@@ -30,9 +30,6 @@ class PatchResolverTask extends CompilerTask {

});

checkMatchingPatchSignatures(element, patch);

element = patch;

- } else {

- compiler.reportError(

- element, MessageKind.PATCH_EXTERNAL_WITHOUT_IMPLEMENTATION);

}

return element;

}