Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Unified Diff: chrome/tools/extract_actions.py

Issue 13180002: Adding metrics for notification clicks and dismissals (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reviews Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/tools/chromeactions.txt ('K') | « chrome/tools/chromeactions.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/tools/extract_actions.py
diff --git a/chrome/tools/extract_actions.py b/chrome/tools/extract_actions.py
index cba2c9c3b124c2ae279cde559d061a84ffcadf42..62512af762563af63f8922a94aa6d28ff53b8b8c 100755
--- a/chrome/tools/extract_actions.py
+++ b/chrome/tools/extract_actions.py
@@ -336,6 +336,12 @@ def AddExtensionActions(actions):
actions.add('FileBrowser.PhotoEditor.Edit')
actions.add('FileBrowser.PhotoEditor.View')
+ # Actions sent by Google Now client.
+ actions.add('GoogleNow.MessageClicked')
+ actions.add('GoogleNow.ButtonClicked0')
+ actions.add('GoogleNow.ButtonClicked1')
+ actions.add('GoogleNow.Dismissed')
+
def GrepForActions(path, actions):
"""Grep a source file for calls to UserMetrics functions.
@@ -541,7 +547,7 @@ def main(argv):
AddBookmarkManagerActions(actions)
if hash_output:
- f = open(chromeactions_path, "w")
+ f = open(chromeactions_path, "wb")
# Print out the actions as a sorted list.
« chrome/tools/chromeactions.txt ('K') | « chrome/tools/chromeactions.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698