Adding metrics for notification clicks and dismissals

chrome/tools/extract_actions.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Extract UserMetrics "actions" strings from the Chrome source.
 
 This program generates the list of known actions we expect to see in the
 user behavior logs.  It walks the Chrome source, looking for calls to
 UserMetrics functions, extracting actions and warning on improper calls,
@@ skipping 318 matching lines @@
   """Add actions reported by extensions via chrome.metricsPrivate API.
 
   Arguments:
     actions: set of actions to add to.
   """
   # Actions sent by Chrome OS File Browser.
   actions.add('FileBrowser.CreateNewFolder')
   actions.add('FileBrowser.PhotoEditor.Edit')
   actions.add('FileBrowser.PhotoEditor.View')
 
+  # Actions sent by Google Now client.
+  actions.add('GoogleNow.MessageClicked')
+  actions.add('GoogleNow.ButtonClicked0')
+  actions.add('GoogleNow.ButtonClicked1')
+  actions.add('GoogleNow.Dismissed')
+
 def GrepForActions(path, actions):
   """Grep a source file for calls to UserMetrics functions.
 
   Arguments:
     path: path to the file
     actions: set of actions to add to
   """
   global number_of_files_total
   number_of_files_total = number_of_files_total + 1
   # we look for the UserMetricsAction structure constructor
@@ skipping 185 matching lines @@
   # print "Scanned {0} number of files".format(number_of_files_total)
   # print "Found {0} entries".format(len(actions))
 
   AddClosedSourceActions(actions)
   AddChromeOSActions(actions)
   AddExtensionActions(actions)
   AddAndroidActions(actions)
   AddBookmarkManagerActions(actions)
 
   if hash_output:
-    f = open(chromeactions_path, "w")
+    f = open(chromeactions_path, "wb")
 
 
   # Print out the actions as a sorted list.
   for action in sorted(actions):
     if hash_output:
       hash = hashlib.md5()
       hash.update(action)
       print >>f, '0x%s\t%s' % (hash.hexdigest()[:16], action)
     else:
       print action
 
   if hash_output:
     print "Done. Do not forget to add chromeactions.txt to your changelist"
   return 0
 
 
 if '__main__' == __name__:
   sys.exit(main(sys.argv))