Chromium Code Reviews Chromium Code Reviews
Issue
1317883002:
Revert of Centralize deferred commit conditions. (Closed)
DescriptionRevert of Centralize deferred commit conditions. (patchset #1 id:1 of https://codereview.chromium.org/1300043003/ )
Reason for revert:
Perf regression due to an error. willInsertBody is actually before the body is available which means the check for body() in this patch would not succeed and we'd end up not resuming commits until we finished parsing if all sheets were done loading before we got to the <body>.
BUG=524172
Original issue's description:
> Centralize deferred commit conditions.
>
> Instead of having many callbacks that implicitly have conditions for when the
> blink frame pipeline should run, have a function on Document that checks them
> explicitly and make WebViewImpl call it.
>
> This will allow checking if iframes are ready to begin running their lifecycle
> phases when iterating the frame tree in ::beginFrame and ::layout().
>
> BUG=521692
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200783
TBR=ojan@chromium.org,dglazkov@chromium.org,skyostil@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=521692
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201232
Patch Set 1 #
Created: 5 years, 3 months ago
(Patch set is too large to download)
Messages
Total messages: 7 (3 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||
