Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1300043003: Centralize deferred commit conditions. (Closed)

Created:
5 years, 4 months ago by esprehn
Modified:
5 years, 4 months ago
Reviewers:
ojan, Sami, dglazkov
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Centralize deferred commit conditions. Instead of having many callbacks that implicitly have conditions for when the blink frame pipeline should run, have a function on Document that checks them explicitly and make WebViewImpl call it. This will allow checking if iframes are ready to begin running their lifecycle phases when iterating the frame tree in ::beginFrame and ::layout(). BUG=521692 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200783

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -27 lines) Patch
M Source/core/dom/Document.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +14 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +11 lines, -26 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
esprehn
5 years, 4 months ago (2015-08-19 01:10:07 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300043003/1
5 years, 4 months ago (2015-08-19 01:10:30 UTC) #4
ojan
lgtm
5 years, 4 months ago (2015-08-19 01:19:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300043003/1
5 years, 4 months ago (2015-08-19 01:20:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=200783
5 years, 4 months ago (2015-08-19 02:16:10 UTC) #10
esprehn
5 years, 3 months ago (2015-08-26 15:16:49 UTC) #11
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1317883002/ by esprehn@chromium.org.

The reason for reverting is: Perf regression due to an error. willInsertBody is
actually before the body is available which means the check for body() in this
patch would not succeed and we'd end up not resuming commits until we finished
parsing if all sheets were done loading before we got to the <body>.

BUG=524172.

Powered by Google App Engine
This is Rietveld 408576698