Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4017)

Unified Diff: chrome/browser/extensions/active_tab_permission_granter.cc

Issue 131783012: Fix the handling of user gestures for external protocol handler dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix build Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/active_tab_permission_granter.cc
diff --git a/chrome/browser/extensions/active_tab_permission_granter.cc b/chrome/browser/extensions/active_tab_permission_granter.cc
index ecedd3458bd5e6bca93800f98879b9ee0fa16fa4..756007e140c2c731243e4ad4254621aa36e26f92 100644
--- a/chrome/browser/extensions/active_tab_permission_granter.cc
+++ b/chrome/browser/extensions/active_tab_permission_granter.cc
@@ -37,6 +37,9 @@ ActiveTabPermissionGranter::ActiveTabPermissionGranter(
ActiveTabPermissionGranter::~ActiveTabPermissionGranter() {}
void ActiveTabPermissionGranter::GrantIfRequested(const Extension* extension) {
+ // Active tab grant request implies there was a user gesture.
+ web_contents()->UserGestureDone();
not at google - send to devlin 2014/03/28 18:54:23 and this trickles down into the protocol handler s
meacer 2014/03/28 19:53:11 Yes, WebContentsImpl::OnUserGesture calls Resource
+
if (granted_extensions_.Contains(extension->id()))
return;

Powered by Google App Engine
This is Rietveld 408576698