Fix the handling of user gestures for external protocol handler dialogs.

chrome/browser/autocomplete/autocomplete_input.cc

Index: chrome/browser/autocomplete/autocomplete_input.cc
diff --git a/chrome/browser/autocomplete/autocomplete_input.cc b/chrome/browser/autocomplete/autocomplete_input.cc
index ea4285172a6a3c21fd963991f877554d079d22ff..80d870e9e487cb2b0dfd03d94b36cc279818d151 100644
--- a/chrome/browser/autocomplete/autocomplete_input.cc
+++ b/chrome/browser/autocomplete/autocomplete_input.cc
@@ -198,6 +198,7 @@ AutocompleteInput::Type AutocompleteInput::Parse(
     // handlable schemes (e.g. "javascript") may be treated as "blocked" by the
     // external protocol handler because we don't want pages to open them, but
     // users still can.
+    ExternalProtocolHandler::ScopedUserGesture user_gesture;

[not at google - send to devlin, 2014/03/28 18:54:23]

why does autocomplete state imply a user gesture?

[meacer, 2014/03/28 19:53:11]

It doesn't imply a user gesture. GetBlockState takes the user gesture into
account when deciding whether to block the protocol or not, so we fake the
gesture here. Otherwise this would always be blocked.

[not at google - send to devlin, 2014/03/28 20:48:51]

could you rename this variable like "skip_user_gesture_check" or something then?
and/or brief comment?

[meacer, 2014/03/28 20:57:43]

Done.

     ExternalProtocolHandler::BlockState block_state =
         ExternalProtocolHandler::GetBlockState(
             base::UTF16ToUTF8(parsed_scheme));