ui/compositor/test/in_process_context_provider.cc - Issue 1317743002: cc: Implement shared worker contexts. (v1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/compositor/test/in_process_context_provider.cc

Issue 1317743002: cc: Implement shared worker contexts. (v1) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add missing context3d_task_runner_ check Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/compositor/test/in_process_context_provider.cc

diff --git a/ui/compositor/test/in_process_context_provider.cc b/ui/compositor/test/in_process_context_provider.cc

index 76cd19dc191ff8624982205a2d93b573b0058ecb..a6c8d3abe67027b0ca9d095433ffce96056f5a96 100644

--- a/ui/compositor/test/in_process_context_provider.cc

+++ b/ui/compositor/test/in_process_context_provider.cc

@@ -218,7 +218,9 @@ void InProcessContextProvider::SetMemoryPolicyChangedCallback(

}

void InProcessContextProvider::OnLostContext() {

- DCHECK(context_thread_checker_.CalledOnValidThread());

+ // Note: no thread check here as this should not change the thread for which

+ // this context is currently bound. e.g. a worker context might be unbound

+ // and this should not result in it being bound to the current thread.

{

base::AutoLock lock(destroyed_lock_);

if (destroyed_)