Drop SVGElement::getBoundingBox

Drop SVGElement::getBoundingBox

The two users can be trivially replaced with queries on the layout tree
instead.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201973

[fs, 2015-09-08 15:33:53]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[fs, 2015-09-08 15:33:53]

https://codereview.chromium.org/1317563010/diff/1/Source/core/dom/Element.cpp
File Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/1317563010/diff/1/Source/core/dom/Element.cpp...
Source/core/dom/Element.cpp:1000: if (isSVGElement() && layoutObject()) {
This looks like a potential bug for outermost <svg> (missing the viewBox
transform etc). Probably not a very common case though I suspect (only see one
non-test caller.)

https://codereview.chromium.org/1317563010/diff/1/Source/core/dom/Element.cpp...
Source/core/dom/Element.cpp:1047:
quads.append(elementLayoutObject->localToAbsoluteQuad(elementLayoutObject->objectBoundingBox()));
I pondered for a while why this couldn't just use the absoluteQuads override
(oBB vs sBB), and it seems that's the direction the spec has been taking (and
what Gecko/IE/Edge is implementing IIUC). I sent a question to simonp (editor of
CSSOM View) about, and will return to this when I hear from him (hopefully
tomorrow).
I also suspect that we should also just wire up SVG in getClientRects too (and
return the sBB in boundsInViewportSpace). Need to write a few tests for that
though so that it isn't completely bonkers...

[pdr., 2015-09-09 06:45:53]

LGTM

https://codereview.chromium.org/1317563010/diff/1/Source/core/dom/Element.cpp
File Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/1317563010/diff/1/Source/core/dom/Element.cpp...
Source/core/dom/Element.cpp:1047:
quads.append(elementLayoutObject->localToAbsoluteQuad(elementLayoutObject->objectBoundingBox()));
On 2015/09/08 at 15:33:53, fs wrote:
> I pondered for a while why this couldn't just use the absoluteQuads override
(oBB vs sBB), and it seems that's the direction the spec has been taking (and
what Gecko/IE/Edge is implementing IIUC). I sent a question to simonp (editor of
CSSOM View) about, and will return to this when I hear from him (hopefully
tomorrow).
> I also suspect that we should also just wire up SVG in getClientRects too (and
return the sBB in boundsInViewportSpace). Need to write a few tests for that
though so that it isn't completely bonkers...

Please do update us when you find out.

[fs, 2015-09-09 11:08:16]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2015-09-09 11:08:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1317563010/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1317563010/1

[commit-bot: I haz the power, 2015-09-09 12:33:01]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201973