Drop SVGElement::getBoundingBox

Source/core/dom/Element.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
  *           (C) 2007 Eric Seidel (eric@webkit.org)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 979 matching lines @@
 
 IntRect Element::boundsInViewportSpace()
 {
     document().updateLayoutIgnorePendingStylesheets();
 
     FrameView* view = document().view();
     if (!view)
         return IntRect();
 
     Vector<FloatQuad> quads;
     if (isSVGElement() && layoutObject()) {

[fs, 2015/09/08 15:33:53]

This looks like a potential bug for outermost <svg> (missing the viewBox
transform etc). Probably not a very common case though I suspect (only see one
non-test caller.)

         // Get the bounding rectangle from the SVG model.
-        SVGElement* svgElement = toSVGElement(this);
-        FloatRect localRect;
-        if (svgElement->getBoundingBox(localRect))
-            quads.append(layoutObject()->localToAbsoluteQuad(localRect));
+        if (toSVGElement(this)->isSVGGraphicsElement())
+            quads.append(layoutObject()->localToAbsoluteQuad(layoutObject()->objectBoundingBox()));
     } else {
         // Get the bounding rectangle from the box model.
         if (layoutBoxModelObject())
             layoutBoxModelObject()->absoluteQuads(quads);
     }
 
     if (quads.isEmpty())
         return IntRect();
 
     IntRect result = quads[0].enclosingBoundingBox();
@@ skipping 22 matching lines @@
 
 ClientRect* Element::getBoundingClientRect()
 {
     document().updateLayoutIgnorePendingStylesheets();
 
     Vector<FloatQuad> quads;
     LayoutObject* elementLayoutObject = layoutObject();
     if (elementLayoutObject) {
         if (isSVGElement() && !elementLayoutObject->isSVGRoot()) {
             // Get the bounding rectangle from the SVG model.
-            SVGElement* svgElement = toSVGElement(this);
-            FloatRect localRect;
-            if (svgElement->getBoundingBox(localRect))
-                quads.append(elementLayoutObject->localToAbsoluteQuad(localRect));
+            if (toSVGElement(this)->isSVGGraphicsElement())
+                quads.append(elementLayoutObject->localToAbsoluteQuad(elementLayoutObject->objectBoundingBox()));

[fs, 2015/09/08 15:33:53]

I pondered for a while why this couldn't just use the absoluteQuads override
(oBB vs sBB), and it seems that's the direction the spec has been taking (and
what Gecko/IE/Edge is implementing IIUC). I sent a question to simonp (editor of
CSSOM View) about, and will return to this when I hear from him (hopefully
tomorrow).
I also suspect that we should also just wire up SVG in getClientRects too (and
return the sBB in boundsInViewportSpace). Need to write a few tests for that
though so that it isn't completely bonkers...

[pdr., 2015/09/09 06:45:52]

Please do update us when you find out.

         } else if (elementLayoutObject->isBoxModelObject() || elementLayoutObject->isBR()) {
             elementLayoutObject->absoluteQuads(quads);
         }
     }
 
     if (quads.isEmpty())
         return ClientRect::create();
 
     FloatRect result = quads[0].boundingBox();
     for (size_t i = 1; i < quads.size(); ++i)
@@ skipping 2506 matching lines @@
 {
 #if ENABLE(OILPAN)
     if (hasRareData())
         visitor->trace(elementRareData());
     visitor->trace(m_elementData);
 #endif
     ContainerNode::trace(visitor);
 }
 
 } // namespace blink