Introduce composed tree version of localCaretRectOfPosition()

Introduce composed tree version of localCaretRectOfPosition()

This patch introduces composed tree version of |localCaretRectOfPosition()|
by templatizing function to share algorithm.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=webkit_unit_tests --gtest_filter=VisibleUnitsTest.localCaretRectOfPosition

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201124

[yosin_UTC9, 2015-08-25 05:15:26]

yosin@chromium.org changed reviewers:
+ hajimehoshi@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2015-08-25 05:15:40]

PTAL

[yoichio, 2015-08-25 05:24:31]

https://codereview.chromium.org/1317503002/diff/1/Source/core/editing/Visible...
File Source/core/editing/VisibleUnitsTest.cpp (right):

https://codereview.chromium.org/1317503002/diff/1/Source/core/editing/Visible...
Source/core/editing/VisibleUnitsTest.cpp:55: TEST_F(VisibleUnitsTest,
localCaretRectOfPosition)
What does this test test?

[yosin_UTC9, 2015-08-25 05:36:46]

On 2015/08/25 at 05:24:31, yoichio wrote:
>
https://codereview.chromium.org/1317503002/diff/1/Source/core/editing/Visible...
> File Source/core/editing/VisibleUnitsTest.cpp (right):
> 
>
https://codereview.chromium.org/1317503002/diff/1/Source/core/editing/Visible...
> Source/core/editing/VisibleUnitsTest.cpp:55: TEST_F(VisibleUnitsTest,
localCaretRectOfPosition)
> What does this test test?

Checks DOM tree version and composed tree version returns same values.
Caret rectangle should be same for both DOM tree position and composed tree
position if they
point same DOM node.

[yosin_UTC9, 2015-08-25 09:23:48]

Oops, I put into reply

https://codereview.chromium.org/1317503002/diff/1/Source/core/editing/Visible...
File Source/core/editing/VisibleUnitsTest.cpp (right):

https://codereview.chromium.org/1317503002/diff/1/Source/core/editing/Visible...
Source/core/editing/VisibleUnitsTest.cpp:55: TEST_F(VisibleUnitsTest,
localCaretRectOfPosition)
On 2015/08/25 05:24:31, yoichio wrote:
> What does this test test?

Checks DOM tree version and composed tree version returns same values.
Caret rectangle should be same for both DOM tree position and composed tree
position if they
point same DOM node.

[yosin_UTC9, 2015-08-25 09:46:08]

PTAL

Fix test case.

https://codereview.chromium.org/1317503002/diff/1/Source/core/editing/Visible...
File Source/core/editing/VisibleUnitsTest.cpp (right):

https://codereview.chromium.org/1317503002/diff/1/Source/core/editing/Visible...
Source/core/editing/VisibleUnitsTest.cpp:55: TEST_F(VisibleUnitsTest,
localCaretRectOfPosition)
On 2015/08/25 05:24:31, yoichio wrote:
> What does this test test?

Oops, my brain was damaged.
I put expectation into different test case.

[hajimehoshi, 2015-08-25 10:01:16]

lgtm

[yosin, 2015-08-25 10:02:45]

The CQ bit was checked by yosin@google.com

[commit-bot: I haz the power, 2015-08-25 10:03:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1317503002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1317503002/20001

[yoichio, 2015-08-25 10:07:09]

https://codereview.chromium.org/1317503002/diff/20001/Source/core/editing/Vis...
File Source/core/editing/VisibleUnitsTest.cpp (right):

https://codereview.chromium.org/1317503002/diff/20001/Source/core/editing/Vis...
Source/core/editing/VisibleUnitsTest.cpp:70: 
Could you add expectation that LayoutRect and LayoutObject are not null?

[commit-bot: I haz the power, 2015-08-25 10:51:51]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201124