Introduce composed tree version of localCaretRectOfPosition()

Source/core/editing/VisibleUnitsTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/editing/VisibleUnits.h"
 
 #include "core/editing/EditingTestBase.h"
 #include "core/editing/VisiblePosition.h"
 
@@ skipping 34 matching lines @@
     EXPECT_TRUE(inSameLine(positionWithAffinityInDOMTree(*one->firstChild(), 0), positionWithAffinityInDOMTree(*two->firstChild(), 0)));
     EXPECT_FALSE(inSameLine(positionWithAffinityInDOMTree(*one->firstChild(), 0), positionWithAffinityInDOMTree(*five->firstChild(), 0)));
     EXPECT_FALSE(inSameLine(positionWithAffinityInDOMTree(*two->firstChild(), 0), positionWithAffinityInDOMTree(*four->firstChild(), 0)));
 
     EXPECT_FALSE(inSameLine(positionWithAffinityInComposedTree(*one, 0), positionWithAffinityInComposedTree(*two, 0)));
     EXPECT_FALSE(inSameLine(positionWithAffinityInComposedTree(*one->firstChild(), 0), positionWithAffinityInComposedTree(*two->firstChild(), 0)));
     EXPECT_FALSE(inSameLine(positionWithAffinityInComposedTree(*one->firstChild(), 0), positionWithAffinityInComposedTree(*five->firstChild(), 0)));
     EXPECT_TRUE(inSameLine(positionWithAffinityInComposedTree(*two->firstChild(), 0), positionWithAffinityInComposedTree(*four->firstChild(), 0)));
 }
 
+TEST_F(VisibleUnitsTest, localCaretRectOfPosition)

[yoichio, 2015/08/25 05:24:31]

What does this test test?

[yosin_UTC9, 2015/08/25 09:23:48]

Checks DOM tree version and composed tree version returns same values.
Caret rectangle should be same for both DOM tree position and composed tree
position if they
point same DOM node.

[yosin_UTC9, 2015/08/25 09:46:08]

Oops, my brain was damaged.
I put expectation into different test case.

+{
+    const char* bodyContent = "<p id='host'><b id='one'>1</b></p><b id='two'>22</b>";
+    const char* shadowContent = "<b id='two'>22</b><content select=#one></content><b id='three'>333</b>";
+    setBodyContent(bodyContent);
+    setShadowContent(shadowContent);
+    updateLayoutAndStyleForPainting();
+
+}
+
 TEST_F(VisibleUnitsTest, mostBackwardCaretPositionAfterAnchor)
 {
     const char* bodyContent = "<p id='host'><b id='one'>1</b></p><b id='two'>22</b>";
     const char* shadowContent = "<b id='two'>22</b><content select=#one></content><b id='three'>333</b>";
     setBodyContent(bodyContent);
     setShadowContent(shadowContent);
     updateLayoutAndStyleForPainting();
 
-    RefPtrWillBeRawPtr<Element> host = document().getElementById("host");
+    RefPtrWillBeRawPtr<Element> one = document().getElementById("one");
 
-    EXPECT_EQ(Position::lastPositionInNode(host.get()), mostForwardCaretPosition(Position::afterNode(host.get())));
-    EXPECT_EQ(PositionInComposedTree::lastPositionInNode(host.get()), mostForwardCaretPosition(PositionInComposedTree::afterNode(host.get())));
+    LayoutObject* layoutObjectFromDOMTree;
+    LayoutRect layoutRectFromDOMTree = localCaretRectOfPosition(Position(one, 0), layoutObjectFromDOMTree);
+
+    LayoutObject* layoutObjectFromComposedTree;
+    LayoutRect layoutRectFromComposedTree = localCaretRectOfPosition(PositionInComposedTree(one, 0), layoutObjectFromComposedTree);
+
+    EXPECT_EQ(layoutObjectFromDOMTree, layoutObjectFromComposedTree);
+    EXPECT_EQ(layoutRectFromDOMTree, layoutRectFromComposedTree);
 }
 
 TEST_F(VisibleUnitsTest, mostForwardCaretPositionAfterAnchor)
 {
     const char* bodyContent = "<p id='host'><b id='one'>1</b></p>";
     const char* shadowContent = "<b id='two'>22</b><content select=#one></content><b id='three'>333</b>";
     setBodyContent(bodyContent);
     RefPtrWillBeRawPtr<ShadowRoot> shadowRoot = setShadowContent(shadowContent);
     updateLayoutAndStyleForPainting();
 
@@ skipping 22 matching lines @@
     setBodyContent(bodyContent);
     updateLayoutAndStyleForPainting();
     RefPtrWillBeRawPtr<Element> sample1 = document().getElementById("sample1");
     RefPtrWillBeRawPtr<Element> sample2 = document().getElementById("sample2");
 
     EXPECT_FALSE(rendersInDifferentPosition(Position::afterNode(sample1->firstChild()), Position(sample2->firstChild(), 0)));
     EXPECT_FALSE(rendersInDifferentPosition(Position::lastPositionInNode(sample1->firstChild()), Position(sample2->firstChild(), 0)));
 }
 
 } // namespace blink