Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1317493002: clang/win: Enable -Wmicrosoft-unqualified-friend. (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fo real #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M build/common.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Nico
5 years, 3 months ago (2015-08-25 17:34:16 UTC) #2
hans
lgtm
5 years, 3 months ago (2015-08-25 17:35:17 UTC) #3
Nico
5 years, 3 months ago (2015-08-25 18:10:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
22c50af81514a7520cd1fb1fd5a692c7b7beef0a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698