Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1317493002: clang/win: Enable -Wmicrosoft-unqualified-friend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fo real Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 if (current_cpu == "arm") { 7 if (current_cpu == "arm") {
8 import("//build/config/arm.gni") 8 import("//build/config/arm.gni")
9 } 9 }
10 if (current_cpu == "mipsel" || current_cpu == "mips64el") { 10 if (current_cpu == "mipsel" || current_cpu == "mips64el") {
(...skipping 846 matching lines...) Expand 10 before | Expand all | Expand 10 after
857 default_warning_flags += [ "/wd4702" ] # Unreachable code. 857 default_warning_flags += [ "/wd4702" ] # Unreachable code.
858 } 858 }
859 859
860 # Building with Clang on Windows is a work in progress and very 860 # Building with Clang on Windows is a work in progress and very
861 # experimental. See crbug.com/82385. 861 # experimental. See crbug.com/82385.
862 # Keep this in sync with the similar block in build/common.gypi 862 # Keep this in sync with the similar block in build/common.gypi
863 if (is_clang) { 863 if (is_clang) {
864 default_warning_flags += [ 864 default_warning_flags += [
865 # TODO(hans): Make this list shorter eventually, http://crbug.com/504657 865 # TODO(hans): Make this list shorter eventually, http://crbug.com/504657
866 "-Qunused-arguments", # http://crbug.com/504658 866 "-Qunused-arguments", # http://crbug.com/504658
867 "-Wno-microsoft-unqualified-friend", # http://crbug.com/505296
868 "-Wno-microsoft-enum-value", # http://crbug.com/505296 867 "-Wno-microsoft-enum-value", # http://crbug.com/505296
869 "-Wno-unknown-pragmas", # http://crbug.com/505314 868 "-Wno-unknown-pragmas", # http://crbug.com/505314
870 "-Wno-unused-value", # http://crbug.com/505318 869 "-Wno-unused-value", # http://crbug.com/505318
871 ] 870 ]
872 } 871 }
873 } else { 872 } else {
874 # Common GCC warning setup. 873 # Common GCC warning setup.
875 default_warning_flags += [ 874 default_warning_flags += [
876 # Enables. 875 # Enables.
877 "-Wendif-labels", # Weird old-style text after an #endif. 876 "-Wendif-labels", # Weird old-style text after an #endif.
(...skipping 460 matching lines...) Expand 10 before | Expand all | Expand 10 after
1338 cflags += [ "-gsplit-dwarf" ] 1337 cflags += [ "-gsplit-dwarf" ]
1339 } 1338 }
1340 } 1339 }
1341 } 1340 }
1342 1341
1343 config("no_symbols") { 1342 config("no_symbols") {
1344 if (!is_win) { 1343 if (!is_win) {
1345 cflags = [ "-g0" ] 1344 cflags = [ "-g0" ]
1346 } 1345 }
1347 } 1346 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698