ServiceWorker: Clean up ownership management of WebServiceWorkerRegistration

ServiceWorker: Clean up ownership management of WebServiceWorkerRegistration

Before the CL[1], Chromium could pass an existing WebServiceWorkerRegistration
to ServiceWorkerRegistration, so ServiceWorkerRegistration needed to confirm
whether its ownership was passed. After the CL, Chromium always passes ownership
and ServiceWorkerRegistration does not have to worry about it.

This CL removes codes for the case that ownership is not passed from Chromium.

[1] https://codereview.chromium.org/1307133003/

BUG=523904
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201219

[nhiroki, 2015-08-25 09:10:44]

Patchset #1 (id:1) has been deleted

[nhiroki, 2015-08-25 09:13:43]

Patchset #1 (id:20001) has been deleted

[nhiroki, 2015-08-25 09:26:37]

Patchset #1 (id:40001) has been deleted

[nhiroki, 2015-08-25 09:48:37]

nhiroki@chromium.org changed reviewers:
+ falken@chromium.org

[nhiroki, 2015-08-25 09:48:37]

PTAL, thanks!

[falken, 2015-08-26 07:47:57]

this is looking good

https://codereview.chromium.org/1317473002/diff/60001/Source/modules/servicew...
File Source/modules/serviceworkers/ServiceWorkerRegistration.h (right):

https://codereview.chromium.org/1317473002/diff/60001/Source/modules/servicew...
Source/modules/serviceworkers/ServiceWorkerRegistration.h:47: static
ServiceWorkerRegistration* take(ScriptPromiseResolver*,
PassOwnPtr<WebServiceWorkerRegistration>);
Can you document these functions? I don't intuitively grasp the difference
between create and take, especially since take just calls create. I think we
should also mention the caller owns the return value... would it make sense to
return a PassOwnPtr?

[nhiroki, 2015-08-26 08:16:01]

Thank you! Updated.

https://codereview.chromium.org/1317473002/diff/60001/Source/modules/servicew...
File Source/modules/serviceworkers/ServiceWorkerRegistration.h (right):

https://codereview.chromium.org/1317473002/diff/60001/Source/modules/servicew...
Source/modules/serviceworkers/ServiceWorkerRegistration.h:47: static
ServiceWorkerRegistration* take(ScriptPromiseResolver*,
PassOwnPtr<WebServiceWorkerRegistration>);
On 2015/08/26 07:47:57, falken wrote:
> Can you document these functions? I don't intuitively grasp the difference
> between create and take, especially since take just calls create.

Removed take(). take() was used for CallbackPromiseAdapter, but currently we
don't use the adapter and this function is no longer necessary.

> I think we
> should also mention the caller owns the return value... would it make sense to
> return a PassOwnPtr?

I think we don't have to take care of this ownership because
ServiceWorkerRegistration is managed by Oilpan GC.

[falken, 2015-08-26 08:20:42]

yay for making our code simpler! lgtm

nit: s/onwership/ownership in CL description

[nhiroki, 2015-08-26 08:22:59]

On 2015/08/26 08:20:42, falken wrote:
> yay for making our code simpler! lgtm
> 
> nit: s/onwership/ownership in CL description

Fixed. I often do this mistype :p

[nhiroki, 2015-08-26 08:38:19]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2015-08-26 08:38:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1317473002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1317473002/80001

[commit-bot: I haz the power, 2015-08-26 09:29:24]

Committed patchset #2 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201219