ServiceWorker: Clean up ownership management of WebServiceWorkerRegistration

Source/modules/serviceworkers/ServiceWorkerRegistration.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ServiceWorkerRegistration_h
 #define ServiceWorkerRegistration_h
 
 #include "core/dom/ActiveDOMObject.h"
 #include "core/events/EventTarget.h"
 #include "modules/serviceworkers/ServiceWorker.h"
@@ skipping 25 matching lines @@
     // EventTarget overrides.
     const AtomicString& interfaceName() const override;
     ExecutionContext* executionContext() const override { return ActiveDOMObject::executionContext(); }
 
     // WebServiceWorkerRegistrationProxy overrides.
     void dispatchUpdateFoundEvent() override;
     void setInstalling(WebServiceWorker*) override;
     void setWaiting(WebServiceWorker*) override;
     void setActive(WebServiceWorker*) override;
 
-    static ServiceWorkerRegistration* from(ExecutionContext*, WebServiceWorkerRegistration*);
-    static ServiceWorkerRegistration* take(ScriptPromiseResolver*, WebServiceWorkerRegistration*);
+    static ServiceWorkerRegistration* create(ExecutionContext*, PassOwnPtr<WebServiceWorkerRegistration>);
+    static ServiceWorkerRegistration* take(ScriptPromiseResolver*, PassOwnPtr<WebServiceWorkerRegistration>);

[falken, 2015/08/26 07:47:57]

Can you document these functions? I don't intuitively grasp the difference
between create and take, especially since take just calls create. I think we
should also mention the caller owns the return value... would it make sense to
return a PassOwnPtr?

[nhiroki, 2015/08/26 08:16:01]

Removed take(). take() was used for CallbackPromiseAdapter, but currently we
don't use the adapter and this function is no longer necessary.
I think we don't have to take care of this ownership because
ServiceWorkerRegistration is managed by Oilpan GC.

     static void dispose(WebServiceWorkerRegistration*);
 
     ServiceWorker* installing() { return m_installing; }
     ServiceWorker* waiting() { return m_waiting; }
     ServiceWorker* active() { return m_active; }
 
     String scope() const;
 
     WebServiceWorkerRegistration* webRegistration() { return m_outerRegistration.get(); }
 
     ScriptPromise update(ScriptState*);
     ScriptPromise unregister(ScriptState*);
 
     DEFINE_ATTRIBUTE_EVENT_LISTENER(updatefound);
 
     ~ServiceWorkerRegistration() override;
 
     // Eager finalization needed to promptly release owned WebServiceWorkerRegistration.
     EAGERLY_FINALIZE();
     DECLARE_VIRTUAL_TRACE();
 
 private:
-    static ServiceWorkerRegistration* getOrCreate(ExecutionContext*, WebServiceWorkerRegistration*);
     ServiceWorkerRegistration(ExecutionContext*, PassOwnPtr<WebServiceWorkerRegistration>);
 
     // ActiveDOMObject overrides.
     bool hasPendingActivity() const override;
     void stop() override;
 
     OwnPtr<WebServiceWorkerRegistration> m_outerRegistration;
     WebServiceWorkerProvider* m_provider;
     Member<ServiceWorker> m_installing;
     Member<ServiceWorker> m_waiting;
     Member<ServiceWorker> m_active;
 
     bool m_stopped;
 };
 
 class ServiceWorkerRegistrationArray {
     STATIC_ONLY(ServiceWorkerRegistrationArray);
 public:
     static HeapVector<Member<ServiceWorkerRegistration>> take(ScriptPromiseResolver* resolver, PassOwnPtr<WebVector<WebServiceWorkerRegistration*>> webServiceWorkerRegistrations)
     {
         HeapVector<Member<ServiceWorkerRegistration>> registrations;
         for (WebServiceWorkerRegistration* registration : *webServiceWorkerRegistrations)
-            registrations.append(ServiceWorkerRegistration::take(resolver, registration));
+            registrations.append(ServiceWorkerRegistration::take(resolver, adoptPtr(registration)));
         return registrations;
     }
-
-    static void dispose(PassOwnPtr<WebVector<WebServiceWorkerRegistration*>> webServiceWorkerRegistrations)
-    {
-        for (WebServiceWorkerRegistration* registration : *webServiceWorkerRegistrations)
-            ServiceWorkerRegistration::dispose(registration);
-    }
 };
 
 } // namespace blink
 
 #endif // ServiceWorkerRegistration_h