Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Side by Side Diff: chrome/browser/ui/android/connection_info_popup_android.cc

Issue 1317443002: Fix UAF in Origin Info Bubble and permission settings UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix another Andorid call site. Checked all call sites. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/android/website_settings_popup_android.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/android/connection_info_popup_android.h" 5 #include "chrome/browser/ui/android/connection_info_popup_android.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_array.h" 8 #include "base/android/jni_array.h"
9 #include "base/android/jni_string.h" 9 #include "base/android/jni_string.h"
10 #include "chrome/browser/android/resource_mapper.h" 10 #include "chrome/browser/android/resource_mapper.h"
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 web_contents->GetController().GetVisibleEntry(); 85 web_contents->GetController().GetVisibleEntry();
86 if (nav_entry == NULL) 86 if (nav_entry == NULL)
87 return; 87 return;
88 88
89 popup_jobject_.Reset(env, java_website_settings_pop); 89 popup_jobject_.Reset(env, java_website_settings_pop);
90 90
91 presenter_.reset(new WebsiteSettings( 91 presenter_.reset(new WebsiteSettings(
92 this, 92 this,
93 Profile::FromBrowserContext(web_contents->GetBrowserContext()), 93 Profile::FromBrowserContext(web_contents->GetBrowserContext()),
94 TabSpecificContentSettings::FromWebContents(web_contents), 94 TabSpecificContentSettings::FromWebContents(web_contents),
95 InfoBarService::FromWebContents(web_contents), 95 web_contents,
96 nav_entry->GetURL(), 96 nav_entry->GetURL(),
97 nav_entry->GetSSL(), 97 nav_entry->GetSSL(),
98 content::CertStore::GetInstance())); 98 content::CertStore::GetInstance()));
99 } 99 }
100 100
101 ConnectionInfoPopupAndroid::~ConnectionInfoPopupAndroid() { 101 ConnectionInfoPopupAndroid::~ConnectionInfoPopupAndroid() {
102 } 102 }
103 103
104 void ConnectionInfoPopupAndroid::Destroy(JNIEnv* env, jobject obj) { 104 void ConnectionInfoPopupAndroid::Destroy(JNIEnv* env, jobject obj) {
105 delete this; 105 delete this;
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 // There's no tab UI on Android - only connection info is shown. 186 // There's no tab UI on Android - only connection info is shown.
187 NOTIMPLEMENTED(); 187 NOTIMPLEMENTED();
188 } 188 }
189 189
190 // static 190 // static
191 bool 191 bool
192 ConnectionInfoPopupAndroid::RegisterConnectionInfoPopupAndroid( 192 ConnectionInfoPopupAndroid::RegisterConnectionInfoPopupAndroid(
193 JNIEnv* env) { 193 JNIEnv* env) {
194 return RegisterNativesImpl(env); 194 return RegisterNativesImpl(env);
195 } 195 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/android/website_settings_popup_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698