Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: chrome/browser/ui/android/website_settings_popup_android.cc

Issue 1317443002: Fix UAF in Origin Info Bubble and permission settings UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix another Andorid call site. Checked all call sites. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/android/website_settings_popup_android.h" 5 #include "chrome/browser/ui/android/website_settings_popup_android.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_array.h" 8 #include "base/android/jni_array.h"
9 #include "base/android/jni_string.h" 9 #include "base/android/jni_string.h"
10 #include "chrome/browser/infobars/infobar_service.h" 10 #include "chrome/browser/infobars/infobar_service.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 return; 48 return;
49 49
50 url_ = nav_entry->GetURL(); 50 url_ = nav_entry->GetURL();
51 51
52 popup_jobject_.Reset(env, java_website_settings_pop); 52 popup_jobject_.Reset(env, java_website_settings_pop);
53 53
54 presenter_.reset(new WebsiteSettings( 54 presenter_.reset(new WebsiteSettings(
55 this, 55 this,
56 Profile::FromBrowserContext(web_contents->GetBrowserContext()), 56 Profile::FromBrowserContext(web_contents->GetBrowserContext()),
57 TabSpecificContentSettings::FromWebContents(web_contents), 57 TabSpecificContentSettings::FromWebContents(web_contents),
58 InfoBarService::FromWebContents(web_contents), 58 web_contents,
59 nav_entry->GetURL(), 59 nav_entry->GetURL(),
60 nav_entry->GetSSL(), 60 nav_entry->GetSSL(),
61 content::CertStore::GetInstance())); 61 content::CertStore::GetInstance()));
62 } 62 }
63 63
64 WebsiteSettingsPopupAndroid::~WebsiteSettingsPopupAndroid() {} 64 WebsiteSettingsPopupAndroid::~WebsiteSettingsPopupAndroid() {}
65 65
66 void WebsiteSettingsPopupAndroid::Destroy(JNIEnv* env, jobject obj) { 66 void WebsiteSettingsPopupAndroid::Destroy(JNIEnv* env, jobject obj) {
67 delete this; 67 delete this;
68 } 68 }
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 WebsiteSettingsUI::TabId tab_id) { 136 WebsiteSettingsUI::TabId tab_id) {
137 // There's no tab UI on Android - only connection info is shown. 137 // There's no tab UI on Android - only connection info is shown.
138 NOTIMPLEMENTED(); 138 NOTIMPLEMENTED();
139 } 139 }
140 140
141 // static 141 // static
142 bool WebsiteSettingsPopupAndroid::RegisterWebsiteSettingsPopupAndroid( 142 bool WebsiteSettingsPopupAndroid::RegisterWebsiteSettingsPopupAndroid(
143 JNIEnv* env) { 143 JNIEnv* env) {
144 return RegisterNativesImpl(env); 144 return RegisterNativesImpl(env);
145 } 145 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698